Skip to content

Cannot have stop in accelerator region #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sbryngelson opened this issue Feb 3, 2025 · 1 comment · May be fixed by #813
Open

Cannot have stop in accelerator region #797

sbryngelson opened this issue Feb 3, 2025 · 1 comment · May be fixed by #813
Assignees
@dgvacarevelo
Labels
bug Something isn't working or doesn't seem right

Comments

@sbryngelson
Copy link
Member

PR #749 introduces several impermissible statements, at least on AMD GPU hardware and with Cray compilers (v >= 19). The problem is stop statements in the GPU kernels. Examples are here:

MFC/src/simulation/m_bubbles_EL.fpp

Line 992 in 131b41e

stop "Check cluterflag. Exiting."

MFC/src/simulation/m_bubbles_EL.fpp

Line 1127 in 131b41e

if (intfc_rad(k, 1) <= 0._wp) stop "Negative bubble radius encountered, please reduce dt"

MFC/src/simulation/m_bubbles_EL.fpp

Line 1115 in 131b41e

if (intfc_rad(k, 2) <= 0._wp) stop "Negative bubble radius encountered, please reduce dt"

MFC/src/simulation/m_bubbles_EL.fpp

Line 1102 in 131b41e

if (intfc_rad(k, 2) <= 0._wp) stop "Negative bubble radius encountered, please reduce dt"

and so on and so forth.
@sbryngelson sbryngelson added the bug Something isn't working or doesn't seem right label Feb 3, 2025
@sbryngelson
Copy link
Member Author

@dgvacarevelo can you please have a look at this and figure out a workaround? It would be a great help. New compilers do not allow for stop statements in GPU compute regions, which makes sense to me. We can be more judicious, only performing these checks during I/O regions or something? Up to you. My preferred route is whatever is a quick fix but also does not duplicate a ton of code.

@dgvacarevelo dgvacarevelo linked a pull request Mar 31, 2025 that will close this issue
Lagrangian subgrid bubble model #749
Merged
21 tasks
@dgvacarevelo dgvacarevelo removed a link to a pull request Mar 31, 2025
Lagrangian subgrid bubble model #749
Merged
21 tasks
This was referenced Mar 31, 2025
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgvacarevelo dgvacarevelo

Labels
bug Something isn't working or doesn't seem right
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #797 dgvacarevelo/MFC
Fix #797 dgvacarevelo/MFC
2 participants
@sbryngelson @dgvacarevelo