Skip to content

Add zh-tw Locale File for Traditional Chinese Translation #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bee0511 opened this issue Mar 14, 2025 · 3 comments · May be fixed by #1054
Open

Add zh-tw Locale File for Traditional Chinese Translation #1044

bee0511 opened this issue Mar 14, 2025 · 3 comments · May be fixed by #1054

Comments

@bee0511
Copy link

bee0511 commented Mar 14, 2025 •
edited
Loading

Hi there,

I'm a native Traditional Chinese speaker interested in contributing to the Nettacker project. As a first-time contributor, I've started looking into the localization files and noticed that there is no zh-tw.yaml locale file in the nettacker/locale directory. I want to contribute by providing a Traditional Chinese translation.

However, I observed a discrepancy in the number of lines between the existing locale files:

  • en.yaml contains 127 lines
  • zh-cn.yaml contains 194 lines

Could someone please clarify which file should be used as the base for the zh-tw.yaml translation? Should I align with the content of en.yaml or follow the more extensive zh-cn.yaml version?

Thank you for your guidance, and I'm excited to contribute!
@bee0511 bee0511 changed the title Add zh_tw Locale File for Traditional Chinese Translation Add zh-tw Locale File for Traditional Chinese Translation Mar 14, 2025
@Soumyaditya25
Copy link
Contributor

Hi @bee0511 , there is Chinese translation file already exists. Could you please clarify why we need to add a new one? Do you have any suggestions for improvement ?

@bee0511
Copy link
Author

bee0511 commented Mar 18, 2025

Hi, @Soumyaditya25, thanks for your response!

Because the words and phrases used in Simplified and Traditional Chinese are different, and not all Traditional Chinese speakers understand Simplified Chinese, I want to add a Traditional Chinese version.

I also noticed that the difference in the number of lines between the Simplified Chinese and English files is because the Chinese file has many unused parameters. For example, the thread_number_warning parameter was deleted from the English file in commit 5024f1a.

I have two suggestions:

  1. Add a Traditional Chinese locale so that Traditional Chinese users can use Nettacker more easily.
  2. Clean up the unused parameters in the Simplified Chinese file so that its content matches the English version more closely.

@Soumyaditya25
Copy link
Contributor

@bee0511 The suggestion for improvement is appreciated but I believe you can just update the existing Chinese file instead of adding a new one.

@bee0511 bee0511 linked a pull request Mar 31, 2025 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up parameters in locale files bee0511/Nettacker
2 participants
@bee0511 @Soumyaditya25