Skip to content

Ensure all tooling works with Learning #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eric-Arellano opened this issue Apr 22, 2025 · 0 comments · May be fixed by #3033
Open

Ensure all tooling works with Learning #3027

Eric-Arellano opened this issue Apr 22, 2025 · 0 comments · May be fixed by #3033
Assignees

Comments

@Eric-Arellano
Copy link
Collaborator

Very soon, we'll start adding content under the folders learning/ and public/learning. We need to ensure that all of our tooling is working properly. Things to check:

  • ./check
  • ./fix
  • ./start
  • PR previews (requires updating _copy_local_content in builder.py)
  • CI configuration, such as our detection of paths for when to run things

At least to start, learning should run by default. We don't need a --learning argument to any of our scripts.

We have not yet finalized the URL scheme, so focus on getting generic support for learning/ working. The URL will likely be something like /learning/courses/my-course/my-lesson.

Another thing to think about is how the home page for the preview is going to work 🤔 Right now, our preview app home page gives quick links to all of our different folders like /guides. That is really useful. But it's not going to naively work with Courses because each course will be its own folder with its own _toc.json. Naively, we'd need to update the code in closed source to enumerate every course, which requires updating it when a new course is added. That's brittle. Can we do something more clever? (Timebox this investigation to <2 hours)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants