Skip to content

IntegrationTest#test_launch_mode_with_full_bundle fails locally for Ruby 3.1 #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyw8 opened this issue Mar 11, 2025 · 2 comments
Open

Comments

@andyw8
Copy link
Contributor

andyw8 commented Mar 11, 2025

Change .ruby-version to 3.1.4, run dev up, then:

% bundle exec ruby -Itest /Users/andyw8/src/github.com/Shopify/ruby-lsp/test/integration_test.rb --name "/^IntegrationTest(#|::)/"

# Running tests with run options --name "/^IntegrationTest(#|::)/" --seed 14559:

..S...S.E..

Finished tests in 14.330950s, 0.7676 tests/s, 32.5868 assertions/s.


Skipped:
IntegrationTest#test_ruby_lsp_doctor_works [/Users/andyw8/.gem/ruby/3.1.4/gems/minitest-5.25.1/lib/minitest/assertions.rb:833]:
CI only

Skipped:
IntegrationTest#test_ruby_lsp_check_works [/Users/andyw8/.gem/ruby/3.1.4/gems/minitest-5.25.1/lib/minitest/assertions.rb:833]:
CI only

Error:
IntegrationTest#test_launch_mode_with_full_bundle:
NoMethodError: undefined method `[]' for nil:NilClass

    length = headers[/Content-Length: (\d+)/i, 1].to_i
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    test/integration_test.rb:320:in `read_message'
    test/integration_test.rb:286:in `launch'
    test/integration_test.rb:218:in `block (2 levels) in test_launch_mode_with_full_bundle'
    /Users/andyw8/.gem/ruby/3.1.4/gems/bundler-2.6.2/lib/bundler.rb:411:in `block in with_unbundled_env'
    /Users/andyw8/.gem/ruby/3.1.4/gems/bundler-2.6.2/lib/bundler.rb:716:in `with_env'
    /Users/andyw8/.gem/ruby/3.1.4/gems/bundler-2.6.2/lib/bundler.rb:411:in `with_unbundled_env'
    test/integration_test.rb:217:in `block in test_launch_mode_with_full_bundle'
    test/integration_test.rb:327:in `block (2 levels) in in_temp_dir'
    test/integration_test.rb:326:in `chdir'
    test/integration_test.rb:326:in `block in in_temp_dir'
    /opt/rubies/3.1.4/lib/ruby/3.1.0/tmpdir.rb:96:in `mktmpdir'
    test/integration_test.rb:325:in `in_temp_dir'
    test/integration_test.rb:193:in `test_launch_mode_with_full_bundle'
@andyw8
Copy link
Contributor Author

andyw8 commented Mar 11, 2025

@alexcrocha mind checking if you also see this failing locally?

@andyw8 andyw8 changed the title IntegrationTest#test_launch_mode_with_full_bundle fails locally IntegrationTest#test_launch_mode_with_full_bundle fails locally for Ruby 3.1 Mar 11, 2025
@alexcrocha
Copy link
Contributor

I confirm this is failing locally on 3.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants