Skip to content

Object Basics: Contents on array methods is misplaced #29500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 tasks done
MaoShizhong opened this issue Mar 10, 2025 · 5 comments · May be fixed by #29521
Open
3 tasks done

Object Basics: Contents on array methods is misplaced #29500

MaoShizhong opened this issue Mar 10, 2025 · 5 comments · May be fixed by #29521
Assignees
@MaoShizhong
Labels
Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues

Comments

@MaoShizhong
Copy link
Contributor

Checks

Describe your suggestion

In the Foundations Object Basics lesson, it starts off with an intro to objects with docs, then more info on objects vs primitives - all very relevant stuff. Then it suddenly goes on to map/filter/reduce array methods, and some of the assignments are for further array practice.

This seems very out-of-place for a lesson that should be on the basics of JS Objects. We ought to pull array contents, including the array-related assignments, forwards to the Arrays and Loops lesson. Perhaps the first Object Basics assignment (array methods exercises) could be omitted? I feel like array cardio + TOP jS exercises should suffice for the Arrays and Loops lesson.

Object Basics can then be left just on the basics of JS objects, then assign the remaining JS exercises.

Path

Foundations

Lesson Url

https://www.theodinproject.com/lessons/foundations-object-basics

(Optional) Discord Name

No response

(Optional) Additional Comments

No response
@wise-king-sullyman
Copy link
Member

Yet another assessment that I agree with you on!

Perhaps the first Object Basics assignment (array methods exercises) could be omitted?

I actually wonder if it should replace the w3schools array method coverage we have. I haven't dug into the material enough to say for sure at the moment and am happy to leave the call up to you though. I just find that I generally prefer js.info's content over w3schools.

Thanks again!

@MaoShizhong
Copy link
Contributor Author

I'll have a deeper look into those resources and make a call; ultimately, I think we shouldn't have both else it'd be a bit too much. I'll get on this in due course.

@MaoShizhong
Copy link
Contributor Author

@wise-king-sullyman In Object Basics' additional resources, there's a link to the arguments object for functions, linking to a w3schools page on it. w3foolsschools aside, this also feels rather misplaced and even unnecessary to me. Sure, it's an object but it's not really relevant (almost everything out there is an object), and arguments isn't even recommended for use over a rest param. Thoughts on its removal as part of this PR?

@MaoShizhong MaoShizhong linked a pull request Mar 16, 2025 that will close this issue
Open
7 tasks
@wise-king-sullyman
Copy link
Member

@MaoShizhong agree that it sounds like that additional resource could be removed as well

MaoShizhong added a commit to MaoShizhong/curriculum that referenced this issue Mar 17, 2025
@MaoShizhong
Remove arguments object additional resource
4a6b7b4 
As per TheOdinProject#29500 (comment)
Not particularly relevant to the lesson (being an object alone isn't sufficient) and rest params are recommended instead for its purpose anyway.
@github-actions GitHub Actions
Copy link

This issue is stale because it has had no activity for the last 30 days.

@github-actions github-actions bot added the Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaoShizhong MaoShizhong

Labels
Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Object Basics: Move array content to "Arrays and Loops" lesson MaoShizhong/curriculum
2 participants
@wise-king-sullyman @MaoShizhong