Skip to content

Forms and Data Handling: Update link in Knowledge Check #29515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 tasks done
Meltasy opened this issue Mar 14, 2025 · 5 comments · May be fixed by #29524
Open
3 tasks done

Forms and Data Handling: Update link in Knowledge Check #29515

Meltasy opened this issue Mar 14, 2025 · 5 comments · May be fixed by #29524

Comments

@Meltasy
Copy link
Contributor

Meltasy commented Mar 14, 2025

Checks

Describe your suggestion

The final question in the Knowledge Check section has a link to https://owasp.org/www-community/attacks/SQL_Injection. However, this link doesn't appear in the main lesson. So, I'd suggest changing the link tothe section about escaping HTML characters: https://www.theodinproject.com/lessons/nodejs-forms-and-data-handling#escaping-user-input.

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/nodejs-forms-and-data-handling

(Optional) Discord Name

Meltasy

(Optional) Additional Comments

No response
@Anshuman-Jha-01 Anshuman-Jha-01 linked a pull request Mar 17, 2025 that will close this issue
Open
7 tasks
@Anshuman-Jha-01
Copy link

Fixed in PR: #29524

@wise-king-sullyman
Copy link
Member

@Anshuman-Jha-01 while we appreciate your enthusiasm and taking the time to create your PR, we ask that people don't put up PRs for issues without being assigned to them, especially when the person that created the issue marked it as being something they would like to work on.

@Meltasy would you still like to put the PR up for this issue yourself? (and thanks for putting the issue up!)

@Meltasy
Copy link
Contributor Author

Meltasy commented Mar 18, 2025

Yes, I would. I was just waiting for someone to confirm they would like me to complete the change as suggested. Thanks 🙂

@Meltasy
Copy link
Contributor Author

Meltasy commented Mar 30, 2025

Just wanted to check if the TOP team have had time to discuss this issue and/or whether it's related to the Node revamp and so will become redundant in the near future? Thanks and have a lovely day :-)

@CouchofTomato
Copy link
Member

I've asked someone involved in the Node revamp to answer you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forms and Data Handling: Change incorrect link in Knowledge Check Anshuman-Jha-01/curriculum
4 participants
@wise-king-sullyman @CouchofTomato @Meltasy @Anshuman-Jha-01