Skip to content

Chrome deployPercentage option not working #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
msaidzengin opened this issue Apr 7, 2025 · 1 comment · May be fixed by #37
Open

Chrome deployPercentage option not working #36

msaidzengin opened this issue Apr 7, 2025 · 1 comment · May be fixed by #37

Comments

@msaidzengin
Copy link

Description:

The deployPercentage option is not functioning as expected. I noticed that these parameters are not added to the relevant function

publish-browser-extension/src/chrome/chrome-web-store.ts

Lines 50 to 54 in f59eef9

await api.submitForReview({
extensionId: this.options.extensionId,
publishTarget: this.options.publishTarget,
token,
});

Suggested change:

    await api.submitForReview({
      extensionId: this.options.extensionId,
      publishTarget: this.options.publishTarget,
      token,
      deployPercentage: this.options.deployPercentage,
      reviewExemption: this.options.reviewExemption,
    });
@aklinker1
Copy link
Owner

Darn it, it was my fault... Thanks Said 😓

@aklinker1 aklinker1 linked a pull request Apr 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@aklinker1 @msaidzengin