Skip to content

[Enhancement] ignore extra put when checkImmunityTime exceeds the maximum check time range #9320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
WJ66880 opened this issue Apr 10, 2025 · 1 comment · May be fixed by #9321
Open
1 task done

[Enhancement] ignore extra put when checkImmunityTime exceeds the maximum check time range #9320

WJ66880 opened this issue Apr 10, 2025 · 1 comment · May be fixed by #9321

Comments

@WJ66880
Copy link
Contributor

WJ66880 commented Apr 10, 2025

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

For a half message, if its CHECK_IMMUNITY_TIME_IN_SECONDS property is lager than checkMax * checkInterval, then it will never be checked, but still has been put for checkMax times. It's a waste of put.
If we have a lot of trans messages, the put metrics will by nearly 15 times high.

Motivation

Transactional message's property checkImmunityTime has no upper limit, everyone can set a large value, for example 1800 seconds.

Describe the Solution You'd Like

Continue loop and log warn when CHECK_IMMUNITY_TIME_IN_SECONDS property is lager than checkMax * checkInterval.

Describe Alternatives You've Considered

Do not use checkImmunityTime property, but that's not why it is built for.

Additional Context

No response

WJ66880 added a commit to WJ66880/rocketmq that referenced this issue Apr 10, 2025
WJ66880 added a commit to WJ66880/rocketmq that referenced this issue Apr 15, 2025
WJ66880 added a commit to WJ66880/rocketmq that referenced this issue Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant