Skip to content

Commit 77bb7ff

Browse files
committed
feat(helm-chart): Allow custom worker image
This change allows setting a custom image for superset worker but defaulting to the global image configuration set in values.image. This is useful if you want to run the superset node w/o playwright and chromium to reduce the image footprint but having a custom image extension for the worker deployment.
1 parent 26ff734 commit 77bb7ff

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

helm/superset/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ maintainers:
2929
- name: craig-rueda
3030
3131
url: https://github.com/craig-rueda
32-
version: 0.14.2
32+
version: 0.14.3
3333
dependencies:
3434
- name: postgresql
3535
version: 13.4.4

helm/superset/README.md

+3
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,9 @@ On helm this can be set on `extraSecretEnv.SUPERSET_SECRET_KEY` or `configOverri
312312
| supersetWorker.deploymentLabels | object | `{}` | Labels to be added to supersetWorker deployment |
313313
| supersetWorker.extraContainers | list | `[]` | Launch additional containers into supersetWorker pod |
314314
| supersetWorker.forceReload | bool | `false` | If true, forces deployment to reload on each upgrade |
315+
| supersetWorker.image.pullPolicy | string | `"{{ .Values.image.pullPolicy }}"` | |
316+
| supersetWorker.image.repository | string | `"{{ .Values.image.repository }}"` | Default to global image configuration but allow worker specific image |
317+
| supersetWorker.image.tag | string | `"{{ .Values.image.tag }}"` | |
315318
| supersetWorker.initContainers | list | a container waiting for postgres and redis | Init container |
316319
| supersetWorker.livenessProbe.exec.command | list | a `celery inspect ping` command | Liveness probe command |
317320
| supersetWorker.livenessProbe.failureThreshold | int | `3` | |

helm/superset/templates/deployment-worker.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ spec:
9090
{{- end }}
9191
containers:
9292
- name: {{ .Chart.Name }}
93-
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
94-
imagePullPolicy: {{ .Values.image.pullPolicy }}
93+
image: "{{ .Values.supersetWorker.image.repository }}:{{ .Values.supersetWorker.image.tag | default .Chart.AppVersion }}"
94+
imagePullPolicy: {{ .Values.supersetWorker.image.pullPolicy }}
9595
{{- if .Values.supersetWorker.containerSecurityContext }}
9696
securityContext: {{- toYaml .Values.supersetWorker.containerSecurityContext | nindent 12 }}
9797
{{- end }}

helm/superset/values.yaml

+5
Original file line numberDiff line numberDiff line change
@@ -387,6 +387,11 @@ supersetWorker:
387387
minAvailable: 1
388388
# -- If set, minAvailable must not be set - see https://kubernetes.io/docs/tasks/run-application/configure-pdb/#specifying-a-poddisruptionbudget
389389
maxUnavailable: 1
390+
image:
391+
# -- Default to global image configuration but allow worker specific image
392+
repository: "{{ .Values.image.repository }}"
393+
tag: "{{ .Values.image.tag }}"
394+
pullPolicy: "{{ .Values.image.pullPolicy }}"
390395
# -- Worker startup command
391396
# @default -- a `celery worker` command
392397
command:

0 commit comments

Comments
 (0)