Skip to content

Commit 523cac1

Browse files
committed
update versions and fix some tests
1 parent ac22e25 commit 523cac1

20 files changed

+385
-360
lines changed

Directory.Packages.props

+13-12
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,19 @@
88
<GlobalPackageReference Include="Nerdbank.GitVersioning" Version="3.6.146" />
99
</ItemGroup>
1010
<ItemGroup>
11+
<PackageVersion Include="DotNetConfig" Version="1.2.0" />
1112
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
12-
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="17.8.3" />
13-
<PackageVersion Include="Microsoft.Build.Framework" Version="17.8.3" />
14-
<PackageVersion Include="Microsoft.Build.Locator" Version="1.7.8" />
15-
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0" />
13+
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="17.12.6" />
14+
<PackageVersion Include="Microsoft.Build.Framework" Version="17.12.6" />
15+
<PackageVersion Include="Microsoft.Build.Locator" Version="1.6.10" />
16+
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.9.2" />
1617
<PackageVersion Include="Microsoft.Extensions.DependencyModel" Version="8.0.2" />
1718
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="8.0.1" />
1819
<PackageVersion Include="Microsoft.Extensions.FileSystemGlobbing" Version="8.0.0" />
1920
<!--For test TestInstrument_NetstandardAwareAssemblyResolver_PreserveCompilationContext-->
2021
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.2" />
21-
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
22-
<PackageVersion Include="Microsoft.TestPlatform.ObjectModel" Version="17.8.0" />
22+
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
23+
<PackageVersion Include="Microsoft.TestPlatform.ObjectModel" Version="17.11.1" />
2324
<!-- Microsoft.TestPlatform.ObjectModel has a dependency to NuGet.Frameworks with specific version -->
2425
<!-- https://github.com/microsoft/vstest/blob/9a0c41811637edf4afe0e265e08fdd1cb18109ed/src/Microsoft.TestPlatform.ObjectModel/Microsoft.TestPlatform.ObjectModel.csproj#L35-->
2526
<!-- wrong configuration will create "build\coverlet.msbuild.targets(72,5): error : Unable to read beyond the end of the stream." -->
@@ -30,20 +31,20 @@
3031
NuGetFrameworksVersion is defined here https://github.com/microsoft/vstest/blob/9a0c41811637edf4afe0e265e08fdd1cb18109ed/eng/Versions.props#L94C1-L94C1
3132
-->
3233
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
33-
<PackageVersion Include="NuGet.Frameworks" Version="6.8.0" />
34-
<PackageVersion Include="NuGet.Packaging" Version="6.8.0" />
35-
<PackageVersion Include="NuGet.Versioning" Version="6.8.0" />
34+
<PackageVersion Include="NuGet.Frameworks" Version="6.11.1" />
35+
<PackageVersion Include="NuGet.Packaging" Version="6.11.1" />
36+
<PackageVersion Include="NuGet.Versioning" Version="6.11.1" />
3637
<PackageVersion Include="Mono.Cecil" Version="0.11.6" />
37-
<PackageVersion Include="Moq" Version="4.20.70" />
38-
<PackageVersion Include="ReportGenerator.Core" Version="5.2.1" />
38+
<PackageVersion Include="Moq" Version="4.20.72" />
39+
<PackageVersion Include="ReportGenerator.Core" Version="5.3.11" />
3940
<!--For test issue 809 https://github.com/coverlet-coverage/coverlet/issues/809-->
4041
<PackageVersion Include="LinqKit.Microsoft.EntityFrameworkCore" Version="7.1.4" />
4142
<PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
4243
<!--To test issue 1104 https://github.com/coverlet-coverage/coverlet/issues/1104-->
4344
<PackageVersion Include="System.Collections.Immutable" Version="8.0.0" />
4445
<PackageVersion Include="System.Configuration.ConfigurationManager" Version="8.0.0" />
4546
<PackageVersion Include="System.Linq.Async" Version="6.0.1" />
46-
<PackageVersion Include="System.Reflection.Metadata" Version="8.0.0" />
47+
<PackageVersion Include="System.Reflection.Metadata" Version="8.0.1" />
4748
<PackageVersion Include="Tmds.ExecFunction" Version="0.8.0" />
4849
<PackageVersion Include="xunit.v3" Version="1.0.0" />
4950
<PackageVersion Include="xunit.v3.core" Version="1.0.0" />

Documentation/Troubleshooting.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -180,10 +180,10 @@ To use/debug local collectors build we need to tell to our project to restore an
180180
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
181181
<PackageReference Include="xunit.v3" Version="1.0.0" />
182182
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.0">
183-
<PrivateAssets>all</PrivateAssets>
184-
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
185-
</PackageReference>
186-
<PackageReference Include="coverlet.collector" Version="6.0.0" /> <-- My local package version -->
183+
<PrivateAssets>all</PrivateAssets>
184+
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
185+
</PackageReference>
186+
<PackageReference Include="coverlet.collector" Version="6.0.0" /> <-- My local package version -->
187187
</ItemGroup>
188188
189189
<ItemGroup>

test/coverlet.collector.tests/coverlet.collector.tests.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<PropertyGroup>
55
<TargetFrameworks>net8.0</TargetFrameworks>
66
<IsPackable>false</IsPackable>
7+
<OutputType>Exe</OutputType>
78
</PropertyGroup>
89

910
<ItemGroup>
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,25 @@
1-
// Remember to use full name because adding new using directives change line numbers
1+
// Remember to use full name because adding new using directives change line numbers
22

33
namespace Coverlet.Core.Tests
44
{
5-
public class Issue_669_2
5+
public class Issue_669_2
6+
{
7+
private readonly System.Net.Http.HttpClient _httpClient = new System.Net.Http.HttpClient();
8+
9+
async public System.Threading.Tasks.ValueTask<System.Net.Http.HttpResponseMessage> SendRequest()
610
{
7-
private readonly System.Net.Http.HttpClient _httpClient = new System.Net.Http.HttpClient();
11+
using (var requestMessage = new System.Net.Http.HttpRequestMessage(System.Net.Http.HttpMethod.Get, "https://www.google.it"))
12+
{
13+
return await _httpClient.SendAsync(requestMessage).ConfigureAwait(false);
14+
}
15+
}
16+
}
817

9-
async public System.Threading.Tasks.ValueTask<System.Net.Http.HttpResponseMessage> SendRequest()
10-
{
11-
using (var requestMessage = new System.Net.Http.HttpRequestMessage(System.Net.Http.HttpMethod.Get, "https://www.google.it"))
12-
{
13-
return await _httpClient.SendAsync(requestMessage).ConfigureAwait(false);
14-
}
15-
}
18+
class Program
19+
{
20+
static void Main(string[] args)
21+
{
22+
//Console.WriteLine("Hello, World!");
1623
}
24+
}
1725
}

test/coverlet.core.tests.samples.netstandard/coverlet.core.tests.samples.netstandard.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<IsPackable>false</IsPackable>
55
<IsTestProject>false</IsTestProject>
66
<ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally>
7+
<OutputType>Exe</OutputType>
78
</PropertyGroup>
89

910
<ItemGroup>

test/coverlet.core.tests/Coverage/InstrumenterHelper.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ public void Retry(Action action, Func<TimeSpan> backoffStrategy, int maxAttemptC
253253
}
254254
}
255255

256-
// We log to files for debugging pourpose, we can check if instrumentation is ok
256+
// We log to files for debugging purpose, we can check if instrumentation is ok
257257
class Logger : ILogger
258258
{
259259
readonly string _logFile;

test/coverlet.core.tests/Instrumentation/InstrumenterTests.cs

+16-16
Original file line numberDiff line numberDiff line change
@@ -296,19 +296,19 @@ public void TestInstrument_NetStandardAwareAssemblyResolver_FromFolder()
296296
new[] { MetadataReference.CreateFromFile(typeof(object).Assembly.Location) },
297297
new CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary));
298298

299-
Assembly newAssemlby;
299+
Assembly newAssembly;
300300
using (var dllStream = new MemoryStream())
301301
{
302302
EmitResult emitResult = compilation.Emit(dllStream, cancellationToken: TestContext.Current.CancellationToken);
303303
Assert.True(emitResult.Success);
304-
newAssemlby = Assembly.Load(dllStream.ToArray());
304+
newAssembly = Assembly.Load(dllStream.ToArray());
305305
// remove if exists
306306
File.Delete("netstandard.dll");
307307
File.WriteAllBytes("netstandard.dll", dllStream.ToArray());
308308
}
309309

310-
var netstandardResolver = new NetstandardAwareAssemblyResolver(newAssemlby.Location, _mockLogger.Object);
311-
AssemblyDefinition resolved = netstandardResolver.Resolve(AssemblyNameReference.Parse(newAssemlby.FullName));
310+
var netstandardResolver = new NetstandardAwareAssemblyResolver(newAssembly.Location, _mockLogger.Object);
311+
AssemblyDefinition resolved = netstandardResolver.Resolve(AssemblyNameReference.Parse(newAssembly.FullName));
312312

313313
// We check if final netstandard.dll resolved is local folder one and not "official" netstandard.dll
314314
Assert.Equal(Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "netstandard.dll"), Path.GetFullPath(resolved.MainModule.FileName));
@@ -398,27 +398,27 @@ public static IEnumerable<object[]> TestInstrument_ExcludedFilesHelper_Data()
398398
[MemberData(nameof(TestInstrument_ExcludedFilesHelper_Data))]
399399
public void TestInstrument_ExcludedFilesHelper(string[] excludeFilterHelper, ValueTuple<string, bool, bool>[] result)
400400
{
401-
var exludeFilterHelper = new ExcludedFilesHelper(excludeFilterHelper, new Mock<ILogger>().Object);
401+
var exclude2FilterHelper = new ExcludedFilesHelper(excludeFilterHelper, new Mock<ILogger>().Object);
402402
foreach (ValueTuple<string, bool, bool> checkFile in result)
403403
{
404404
if (checkFile.Item3) // run test only on windows platform
405405
{
406406
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
407407
{
408-
Assert.Equal(checkFile.Item2, exludeFilterHelper.Exclude(checkFile.Item1));
408+
Assert.Equal(checkFile.Item2, exclude2FilterHelper.Exclude(checkFile.Item1));
409409
}
410410
}
411411
else
412412
{
413-
Assert.Equal(checkFile.Item2, exludeFilterHelper.Exclude(checkFile.Item1));
413+
Assert.Equal(checkFile.Item2, exclude2FilterHelper.Exclude(checkFile.Item1));
414414
}
415415
}
416416
}
417417

418418
[Fact]
419419
public void SkipEmbeddedPdbWithoutLocalSource()
420420
{
421-
string xunitDll = Directory.GetFiles(Directory.GetCurrentDirectory(), "xunit.core.dll").First();
421+
string xunitDll = Directory.GetFiles(Directory.GetCurrentDirectory(), "xunit.v3.core.dll").First();
422422
var loggerMock = new Mock<ILogger>();
423423

424424
var instrumentationHelper =
@@ -552,7 +552,7 @@ public void TestInstrument_AssemblyMarkedAsExcludeFromCodeCoverage(string attrib
552552
string EmitAssemblyToInstrument(string outputFolder)
553553
{
554554
SyntaxTree attributeClassSyntaxTree = CSharpSyntaxTree.ParseText("[System.AttributeUsage(System.AttributeTargets.Assembly)]public class " + attributeName + ":System.Attribute{}", cancellationToken: TestContext.Current.CancellationToken);
555-
SyntaxTree instrumentableClassSyntaxTree = CSharpSyntaxTree.ParseText($@"
555+
SyntaxTree instrumentedClassSyntaxTree = CSharpSyntaxTree.ParseText($@"
556556
[assembly:{attributeName}]
557557
namespace coverlet.tests.projectsample.excludedbyattribute{{
558558
public class SampleClass
@@ -567,7 +567,7 @@ public int SampleMethod()
567567
", cancellationToken: TestContext.Current.CancellationToken);
568568
CSharpCompilation compilation = CSharpCompilation.Create(attributeName, new List<SyntaxTree>
569569
{
570-
attributeClassSyntaxTree,instrumentableClassSyntaxTree
570+
attributeClassSyntaxTree,instrumentedClassSyntaxTree
571571
}).AddReferences(
572572
MetadataReference.CreateFromFile(typeof(Attribute).Assembly.Location)).
573573
WithOptions(new CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary, false));
@@ -612,9 +612,9 @@ public int SampleMethod()
612612
var instrumentationHelper =
613613
new InstrumentationHelper(new ProcessExitHandler(), new RetryHelper(), new FileSystem(), new Mock<ILogger>().Object,
614614
new SourceRootTranslator(new Mock<ILogger>().Object, new FileSystem()));
615-
CoverageParameters parametes = new();
616-
parametes.ExcludeAttributes = excludedAttributes;
617-
var instrumenter = new Instrumenter(excludedbyattributeDll, "_xunit_excludedbyattribute", parametes, loggerMock.Object, instrumentationHelper, partialMockFileSystem.Object, new SourceRootTranslator(loggerMock.Object, new FileSystem()), new CecilSymbolHelper());
615+
CoverageParameters parameters = new();
616+
parameters.ExcludeAttributes = excludedAttributes;
617+
var instrumenter = new Instrumenter(excludedbyattributeDll, "_xunit_excludedbyattribute", parameters, loggerMock.Object, instrumentationHelper, partialMockFileSystem.Object, new SourceRootTranslator(loggerMock.Object, new FileSystem()), new CecilSymbolHelper());
618618

619619
InstrumenterResult result = instrumenter.Instrument();
620620
Assert.Empty(result.Documents);
@@ -633,7 +633,7 @@ public void TestInstrument_NetstandardAwareAssemblyResolver_PreserveCompilationC
633633
[Fact]
634634
public void TestReachabilityHelper()
635635
{
636-
int[] allInstrumentableLines =
636+
int[] allInstrumentedLines =
637637
new[]
638638
{
639639
// Throws
@@ -680,11 +680,11 @@ public void TestReachabilityHelper()
680680
143, 144,
681681
// WithLeave
682682
163, 164,
683-
// FiltersAndFinallies
683+
// FiltersAndFinally
684684
176, 177, 183, 184, 189, 190, 195, 196, 197
685685
};
686686

687-
int[] expectedToBeInstrumented = allInstrumentableLines.Except(notReachableLines).ToArray();
687+
int[] expectedToBeInstrumented = allInstrumentedLines.Except(notReachableLines).ToArray();
688688

689689
InstrumenterTest instrumenterTest = CreateInstrumentor();
690690
InstrumenterResult result = instrumenterTest.Instrumenter.Instrument();

0 commit comments

Comments
 (0)