Deprecate View any modifier

Author: danielsaidi

RELEASE_NOTES.md

@@ -13,6 +13,7 @@ Thanks to [pnewell](https://github.com/pnewell), SwiftUIKit now supports Catalys
 * The `DateFormatter` init extensions have been deprecated.
 * The `DispatchQueue` `asyncAfter` extension has been deprecated.
 * The `JsonEncoder/Decoder` date extensions have been deprecated.
+* The `View` `any()` extension should NOT be used and has been deprecated.
 
 
 

Sources/SwiftUIKit/Presentation/FullScreenCoverContext.swift

@@ -36,7 +36,7 @@ public class FullScreenCoverContext: PresentationContext<AnyView> {
     public func present<Cover: View>(
         _ cover: @autoclosure @escaping () -> Cover
     ) {
-        presentContent(cover().any())
+        presentContent(AnyView(cover()))
     }
 }
 
@@ -53,7 +53,7 @@ public extension View {
     ) -> some View {
         fullScreenCover(
             isPresented: context.isActiveBinding,
-            content: context.content ?? EmptyView().any
+            content: context.content ?? { AnyView(EmptyView()) }
         )
         .environmentObject(context)
     }

Sources/SwiftUIKit/Presentation/SheetContext.swift

@@ -36,7 +36,7 @@ public class SheetContext: PresentationContext<AnyView> {
 
     @MainActor
     public func present<Sheet: View>(_ sheet: @autoclosure @escaping () -> Sheet) {
-        presentContent(sheet().any())
+        presentContent(AnyView(sheet()))
     }
 }
 
@@ -48,7 +48,7 @@ public extension View {
     func sheet(_ context: SheetContext) -> some View {
         sheet(
             isPresented: context.isActiveBinding,
-            content: context.content ?? EmptyView().any
+            content: context.content ?? { AnyView(EmptyView()) }
         )
         .environmentObject(context)
     }

Sources/SwiftUIKit/Progress/CircularProgressBar.swift

@@ -54,25 +54,27 @@ private extension CircularProgressBar {
 
     var progressCircle: some View {
         style.progressModifier(
-            Circle()
+            AnyView(
+                Circle()
                 .trim(from: 0.0, to: CGFloat(progress))
                 .rotation(.degrees(style.startAngle - 90))
                 .stroke(style: StrokeStyle(lineWidth: style.progressWidth, lineCap: .round, lineJoin: .round))
                 .foregroundColor(style.progressColor)
                 .animation(style.animation, value: progress)
-                .any()
+            )
         )
     }
 
     @ViewBuilder
     var progressText: some View {
         if style.showTitle {
             style.titleModifier(
-                Text("\(progressValue, specifier: "%.\(style.decimals)f")%")
-                    .lineLimit(1)
-                    .font(style.titleFont)
-                    .foregroundColor(style.titleColor)
-                    .any()
+                AnyView(
+                    Text("\(progressValue, specifier: "%.\(style.decimals)f")%")
+                        .lineLimit(1)
+                        .font(style.titleFont)
+                        .foregroundColor(style.titleColor)
+                )
             )
         }
     }
@@ -94,14 +96,12 @@ private extension CircularProgressBar {
                 CircularProgressBar(progress: progress)
 
                 CircularProgressBar(progress: progress)
-                .shadow(.elevated)
-                .circularProgressBarStyle(.swedish)
+                    .shadow(.elevated)
+                    .circularProgressBarStyle(.swedish)
 
-                CircularProgressBar(
-                    progress: progress
-                )
-                .shadow(.sticker)
-                .circularProgressBarStyle(.noText)
+                CircularProgressBar(progress: progress)
+                    .shadow(.sticker)
+                    .circularProgressBarStyle(.noText)
 
                 Button("Preview.Progress") {
                     progress += 0.1
@@ -128,10 +128,10 @@ fileprivate extension CircularProgressBar.Style {
         style.startAngle = 45
         style.progressColor = .yellow
         style.progressWidth = 15
-        style.progressModifier = { $0.shadow(.elevated).any() }
+        style.progressModifier = { AnyView($0.shadow(.elevated)) }
         style.titleColor = .yellow
         style.titleFont = .title.bold()
-        style.titleModifier = { $0.shadow(.elevated).any() }
+        style.titleModifier = { AnyView($0.shadow(.elevated)) }
         return style
     }
 

Sources/SwiftUIKit/Views/FetchedDataView.swift

@@ -62,7 +62,7 @@ public struct FetchedDataView<Model, Content: View, LoadingView: View, NoDataVie
     struct Preview: View {
 
         let nilData: String? = nil
-        let content: (String) -> AnyView = { Text($0).any() }
+        let content: (String) -> Text = { .init($0) }
         let loadingView = Text("Preview.Loading")
         let noDataView = Text("Preview.NoData")
 

Sources/SwiftUIKit/Extensions/View+AnyView.swift renamed to Sources/SwiftUIKit/_Deprecated/View+AnyView.swift

@@ -10,10 +10,7 @@ import SwiftUI
 
 public extension View {
 
-    /// Wrap the view in an `AnyView`.
-    ///
-    /// > Important: Do not misuse AnyView. It esmess up the
-    /// view identity, which messes up animations, state etc.
+    @available(*, deprecated, message: "This should not be used and will be removed in the next major release.")
     func any() -> AnyView {
         AnyView(self)
     }