Skip to content

Commit d938748

Browse files
nshahanCommit Queue
authored and
Commit Queue
committed
[ddc] Update ddb script for new ddc modules
Add a body tag to the html dart:html can work when running in chrome. Change-Id: I0d046d8033a734bd610091c52d1410cc72edec84 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423521 Reviewed-by: Srujan Gaddam <[email protected]> Commit-Queue: Nicholas Shahan <[email protected]>
1 parent 5eef8e4 commit d938748

File tree

1 file changed

+13
-8
lines changed
  • pkg/dev_compiler/tool

1 file changed

+13
-8
lines changed

Diff for: pkg/dev_compiler/tool/ddb

+13-8
Original file line numberDiff line numberDiff line change
@@ -349,14 +349,19 @@ sdk.dart.jsInteropNonNullAsserts($jsInteropNonNullAsserts);
349349
for (var output in outputs) '<script src="$output"></script>'
350350
].join('\n');
351351
var ddcModulesHtml = '''
352-
<script src="$preamblesDir/seal_native_object.js"></script>
353-
<script src="$ddcPath/lib/js/ddc/ddc_module_loader.js"></script>
354-
<script src="$sdkJsPath/dart_sdk.js"></script>
355-
$ddcModuleScriptTags
356-
<script>
357-
$ddcModuleSdkOptions
358-
$ddcModuleRunMain
359-
</script>
352+
<html>
353+
<head></head>
354+
<body>
355+
<script src="$preamblesDir/seal_native_object.js"></script>
356+
<script src="$ddcPath/lib/js/ddc/ddc_module_loader.js"></script>
357+
<script src="$sdkJsPath/dart_sdk.js"></script>
358+
$ddcModuleScriptTags
359+
<script>
360+
$ddcModuleSdkOptions
361+
$ddcModuleRunMain
362+
</script>
363+
</body>
364+
</html>
360365
''';
361366
var htmlFile = p.setExtension(entryPoint, '.html');
362367
File(htmlFile)

0 commit comments

Comments
 (0)