Fix no selection tab being visible as subtabs with the sidebar design

david-swift · david-swift · commit 8f031e4d5744 · 2023-09-21T19:42:26.000+02:00
diff --git a/Sources/SettingsKit/Model/Data/SettingsTab.swift b/Sources/SettingsKit/Model/Data/SettingsTab.swift
@@ -101,8 +101,8 @@ public struct SettingsTab: Identifiable, View {
             NavigationStack {
                 Form {
                     ForEach(content) { content in
-                        NavigationLink(value: content.id) {
-                            content.sidebarLabel
+                        if !content.type.isNoSelection {
+                            NavigationLink(value: content.id) { content.sidebarLabel }
                         }
                     }
                     if !sidebarActions.isEmpty {

Original file line number	Diff line number	Diff line change
`@@ -101,8 +101,8 @@ public struct SettingsTab: Identifiable, View {`
`101`	`101`	`NavigationStack {`
`102`	`102`	`Form {`
`103`	`103`	`ForEach(content) { content in`
`104`		`- NavigationLink(value: content.id) {`
`105`		`- content.sidebarLabel`
	`104`	`+ if !content.type.isNoSelection {`
	`105`	`+ NavigationLink(value: content.id) { content.sidebarLabel }`
`106`	`106`	`}`
`107`	`107`	`}`
`108`	`108`	`if !sidebarActions.isEmpty {`