Skip to content

[Core] Investigate building toMountPoint in a shared bundle #218027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tsullivan opened this issue Apr 11, 2025 · 1 comment · Fixed by #218644
Closed

[Core] Investigate building toMountPoint in a shared bundle #218027

tsullivan opened this issue Apr 11, 2025 · 1 comment · Fixed by #218644
Assignees
@kowalczyk-krzysztof
Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@tsullivan
Copy link
Member

This is to follow up on #212163 (comment)

Details
src/platform/packages/shared/react/kibana_mount/to_mount_point.tsx is used in several dozens of plugins. The impact of adding a few bytes to the toMountPoint utility spread to many places. We should investigate moving this utility into a shared bundle (kbn-ui-shared-deps-src).
@tsullivan tsullivan added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Apr 11, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan tsullivan mentioned this issue Apr 11, 2025
Merged
3 tasks
@kowalczyk-krzysztof kowalczyk-krzysztof mentioned this issue Apr 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kowalczyk-krzysztof kowalczyk-krzysztof

Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add react-kibana-mount to shared deps kowalczyk-krzysztof/kibana
3 participants
@tsullivan @elasticmachine @kowalczyk-krzysztof