Skip to content

[FR] using raise ... from ... to improve sdk debugging #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
soof-golan opened this issue Mar 24, 2023 · 1 comment · May be fixed by #686
Open

[FR] using raise ... from ... to improve sdk debugging #685

soof-golan opened this issue Mar 24, 2023 · 1 comment · May be fixed by #686
Labels
api: core type: feature request

Comments

@soof-golan
Copy link

Is your feature request related to a problem? Please describe.
Hey firebase team 👋

I'm always frustrated when an internal error occurs in the sdk, but during handling an that internal error you the sdk raises another and that wipes some of the context of the original error.

Describe the solution you'd like
It would be really nice to use python's built-in raise ... from ... idiom to make the debugging experience better.
It is very feasible and easy to append a from error to any raise statement that references the original error.

Describe alternatives you've considered
Debuggin without this feature 😅

Additional context
I'll gladly implement this. PR coming soon :)
@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@soof-golan soof-golan linked a pull request Mar 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: core type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use raise ... from ... idiom soof-golan/firebase-admin-python
3 participants
@google-oss-bot @soof-golan @jonathanedey