-
Notifications
You must be signed in to change notification settings - Fork 630
Adding Support for Repository Related Security Actions #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd like to work on this issue, here is my plan:
I have already got a high level overview about this enhancement and its implementation, before I submit a PR, I would appreciate any recommendations or confirmations about:
|
Small suggestion to make the dependabot pattern use As per {
"enabled": true,
"paused": false
} |
Thanks for the suggestion @TotalDwarf03 , I see your point about the
{
"enabled": true,
"paused": false
} Let me know if you would like me to adjust this approach or if you have any other suggestions, I'd be happy to hear from any existing contributor/maintainer as I started drafting the implementation. |
To be more concise:
This discrepancy is why I commented out the EnableDependabotSecurityUpdates and DisableDependabotSecurityUpdates functions and documented the issue in the code. |
UPDATEI created the PR for the sole purpose of sharing what I did so far, I am trying to figure out a solution to the issue of the remaining tools ( |
Thanks for this, I actually had a draft PR for enabling some security features before launch. #52 What delayed me was that the API is not super well matched to what we would want to present here, but I intend to finish it soon. Some sibling properties like push protection also require secret scanning to be on first. Effectively I want to think this through carefully first. Part of the problem is also that there are many scenarios where it would fail (org hasn't purchased the product, banned by policy). LMK if you have ideas on how best to model the interaction on the LLM side. |
Thanks for your comment, to sum up issues are:
For now, we can:
For example:
would you like to collaborate on implementing these improvements? i can help with:
We can create a wrapper around github API that validate and give clear status info, what do u think? |
Sorry for the delay, I have had a lot of things to look at and the next couple of weeks are likely to be very busy too. I am certainly not against collaborating on your fork if needed to get the feature completed. I do think it would be pretty cool to get this feature made. Making repos more secure with this is a nice touch. |
No worries :) I created a PR for this issue if you looked at it by any chance you will see that I commented 2 tools in the code which had the issue you faced previously, so we can figure them out and im open to your opinion about them, regarding the rest of code works like a charm with my tests just needs reviews for any optimization. |
Describe the feature or problem you’d like to solve
Enable functionality for Dependabot, Secret Scanning and Push Protection for repositories.
It would be good to be able to:
Proposed solution
Add endpoints for Dependabot, Secret Scanning and Push Protection for repositories.
Additional context
Secret Scanning & Push Protection
Within the REST API's
GET /repos/{owner}/{repo}
, there is asecurity_and_analysis
block:https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#get-a-repository
Dependabot
Replication of
GET /repos/{owner}/{repo}/automated-security-fixes
https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#check-if-dependabot-security-updates-are-enabled-for-a-repository
The text was updated successfully, but these errors were encountered: