Skip to content

Local test docker env broken #19532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
cconard96 opened this issue Apr 24, 2025 · 1 comment · May be fixed by #19535
Open
2 tasks done

Local test docker env broken #19532

cconard96 opened this issue Apr 24, 2025 · 1 comment · May be fixed by #19535
Assignees

Comments

@cconard96
Copy link
Contributor

Code of Conduct

  • I agree to follow this project's Code of Conduct

Is there an existing issue for this?

  • I have searched the existing issues

Version

11.0.0-beta2

Bug description

Broken since cf4354c.

Upon running a test using tests/run_tests.php, when it does the install GLPI step,Symfony complains about replacing the logger service because it is private. Clearly, the setting of it as synthetic is broken.

Not sure if it just affects me or if this feature wasn't testing during review but clearly it works in CI somehow. I removed my local_define.php during testing and it doesn't change the result for me.

Running "install" test suite 
+ LOG_FILE=./tests/files/_log/install.log
++ dirname ./tests/files/_log/install.log
+ mkdir -p ./tests/files/_log
+ bin/console system:check_requirements
Symfony\Component\DependencyInjection\Exception\InvalidArgumentException {#35
  #message: "The "logger" service is private, you cannot replace it."
  #code: 0
  #file: "./vendor/symfony/dependency-injection/Container.php"
  #line: 165
  trace: {
    ./vendor/symfony/dependency-injection/Container.php:165 { …}
    ./src/Glpi/Kernel/Kernel.php:127 {
      Glpi\Kernel\Kernel->boot(): void
      › // Define synthetic logger service
      › $this->container->set('logger', $this->logger);
      › 
      arguments: {
        $id: "logger"
        $service: Monolog\Logger {#18 …}
      }
    }
    ./src/Glpi/Console/Application.php:108 { …}
    ./bin/console:156 { …}
  }
}
 Tests "install" failed

Relevant log output

Page URL

No response

Steps To reproduce

No response

Your GLPI setup information

No response

Anything else?

No response

@cconard96 cconard96 linked a pull request Apr 24, 2025 that will close this issue
4 tasks
@SebSept
Copy link
Contributor

SebSept commented Apr 25, 2025

I guess, it's ./tests/run_tests.sh install command.
It's ok my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants