Skip to content

Lower the threshold for Lighthouse accessibility #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
choldgraf opened this issue Apr 9, 2025 · 2 comments · Fixed by #792
Closed

Lower the threshold for Lighthouse accessibility #791

choldgraf opened this issue Apr 9, 2025 · 2 comments · Fixed by #792

Comments

@choldgraf
Copy link
Collaborator

choldgraf commented Apr 9, 2025

I propose that we lower the threshold of accessibility for lighthouse, and create an issue that states our goal for accessibility on the website. Here is my rationale:

  • Currently, our lighthouse CI is failing on every PR. The last time I looked, we were averaging a score of ~.8 while the threshold is .95
  • This has created an "expected failures" CI dynamic.
  • This means that we aren't actually catching regressions in accessibility, which is what CI is most-useful for doing. It is simply telling us "your accessibility is still below threshold" on every PR.

For this reason:

  • I suggest lowering the threshold we use for CI so that it becomes a useful indicator again and can be used to influence PR decisions.
  • I suggest we open an issue that defines the goal for lighthouse accessibility we want to hit
@krassowski
Copy link
Member

We can set the threshold on per-category basis (as we already do):

"categories:performance": ["error", { "minScore": 0.90 }],
"categories:accessibility": ["error", { "minScore": 0.95 }],
"categories:best-practices": ["error", { "minScore": 0.90 }],
"categories:seo": ["error", { "minScore": 0.95 }]

@krassowski
Copy link
Member

I opened #792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants