Skip to content

Commit 7e4f71a

Browse files
committed
Fix custom preflight tests to use subtests
1 parent 8ff25d5 commit 7e4f71a

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

Diff for: middleware/cors_test.go

+9-8
Original file line numberDiff line numberDiff line change
@@ -706,16 +706,17 @@ func TestCORSWithConfig_PreflightStatusCode(t *testing.T) {
706706
e := echo.New()
707707

708708
for _, tc := range tests {
709-
req := httptest.NewRequest(http.MethodOptions, "/", nil)
710-
rec := httptest.NewRecorder()
711-
712-
c := e.NewContext(req, rec)
709+
t.Run(tc.name, func(t *testing.T) {
710+
req := httptest.NewRequest(http.MethodOptions, "/", nil)
711+
rec := httptest.NewRecorder()
713712

714-
cors := tc.mw(echo.NotFoundHandler)
715-
err := cors(c)
713+
c := e.NewContext(req, rec)
716714

717-
assert.NoError(t, err)
718-
assert.Equal(t, rec.Result().StatusCode, tc.expectedStatusCode)
715+
cors := tc.mw(echo.NotFoundHandler)
716+
err := cors(c)
719717

718+
assert.NoError(t, err)
719+
assert.Equal(t, rec.Result().StatusCode, tc.expectedStatusCode)
720+
})
720721
}
721722
}

0 commit comments

Comments
 (0)