Removed unnecessary else by returning early

Author: tabuna

src/CommonMark/IndentedCodeBlockRenderer.php

@@ -35,8 +35,8 @@ public function render(Node $node, ChildNodeRendererInterface $childRenderer)
 
         if ($theme instanceof WebTheme) {
             return $theme->preBefore($highlighter) . $parsed . $theme->preAfter($highlighter);
-        } else {
-            return '<pre data-lang="' . $language . '" class="notranslate">' . $parsed . '</pre>';
         }
+
+        return sprintf('<pre data-lang="%s" class="notranslate">%s</pre>', $language, $parsed);
     }
 }

src/Languages/CommonPatterns/DoubleQuoteValuePattern.php

@@ -18,7 +18,8 @@ final class DoubleQuoteValuePattern implements Pattern
 
     public function __construct(
         private string $tokenType = 'hl-value',
-    ) {
+    )
+    {
     }
 
     public function canNotContain(): self
@@ -35,13 +36,10 @@ public function getPattern(): string
 
     public function getTokenType(): TokenType
     {
-        if ($this->canNotContain)
-        {
+        if ($this->canNotContain) {
             return new CanNotContainTokenType($this->tokenType);
         }
-        else
-        {
-            return new DynamicTokenType($this->tokenType);
-        }
+
+        return new DynamicTokenType($this->tokenType);
     }
 }

src/Languages/CommonPatterns/GenericPattern.php

@@ -19,7 +19,8 @@ final class GenericPattern implements Pattern
     public function __construct(
         private string $pattern,
         private string $tokenType,
-    ) {
+    )
+    {
     }
 
     public function canNotContain(): self
@@ -36,13 +37,10 @@ public function getPattern(): string
 
     public function getTokenType(): TokenType
     {
-        if ($this->canNotContain)
-        {
+        if ($this->canNotContain) {
             return new CanNotContainTokenType($this->tokenType);
         }
-        else
-        {
-            return new DynamicTokenType($this->tokenType);
-        }
+
+        return new DynamicTokenType($this->tokenType);
     }
 }

src/Languages/CommonPatterns/KeywordPattern.php

@@ -21,7 +21,8 @@ final class KeywordPattern implements Pattern
     public function __construct(
         private string $keyword,
         private string $tokenType = 'hl-keyword',
-    ) {
+    )
+    {
     }
 
     public function caseInsensitive(): self
@@ -51,13 +52,10 @@ public function getPattern(): string
 
     public function getTokenType(): TokenType
     {
-        if ($this->canNotContain)
-        {
+        if ($this->canNotContain) {
             return new CanNotContainTokenType($this->tokenType);
         }
-        else
-        {
-            return new DynamicTokenType($this->tokenType);
-        }
+
+        return new DynamicTokenType($this->tokenType);
     }
 }

src/Languages/CommonPatterns/SingleQuoteValuePattern.php

@@ -18,7 +18,8 @@ final class SingleQuoteValuePattern implements Pattern
 
     public function __construct(
         private string $tokenType = 'hl-value',
-    ) {
+    )
+    {
     }
 
     public function canNotContain(): self
@@ -35,13 +36,10 @@ public function getPattern(): string
 
     public function getTokenType(): TokenType
     {
-        if ($this->canNotContain)
-        {
+        if ($this->canNotContain) {
             return new CanNotContainTokenType($this->tokenType);
         }
-        else
-        {
-            return new DynamicTokenType($this->tokenType);
-        }
+
+        return new DynamicTokenType($this->tokenType);
     }
 }