Added Trim overloads

Author: linkdotnet

CHANGELOG.md

@@ -6,6 +6,10 @@ All notable changes to **ValueStringBuilder** will be documented in this file. T
 
 ## [Unreleased]
 
+### Added
+
+- New overloads for `Trim`, `TrimStart` and `TrimEnd` that accept a character as parameter
+
 ## [1.15.0] - 2023-03-26
 
 ### Added

src/LinkDotNet.StringBuilder/ValueStringBuilder.Trim.cs

@@ -32,6 +32,35 @@ public void Trim()
         }
     }
 
+    /// <summary>
+    /// Removes the specified character from the beginning and end of this string.
+    /// </summary>
+    /// <param name="c">The character to remove.</param>
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
+    public void Trim(char c)
+    {
+        // Remove character from the beginning
+        var start = 0;
+        while (start < bufferPosition && buffer[start] == c)
+        {
+            start++;
+        }
+
+        // Remove character from the end
+        var end = bufferPosition - 1;
+        while (end >= start && buffer[end] == c)
+        {
+            end--;
+        }
+
+        var newLength = end - start + 1;
+        if (newLength < bufferPosition)
+        {
+            bufferPosition = newLength;
+            buffer.Slice(start, start + newLength).CopyTo(buffer);
+        }
+    }
+
     /// <summary>
     /// Removes a set of whitespace characters from the beginning of this string.
     /// </summary>
@@ -52,6 +81,27 @@ public void TrimStart()
         }
     }
 
+    /// <summary>
+    /// Removes the specified character from the beginning of this string.
+    /// </summary>
+    /// <param name="c">The character to remove.</param>
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
+    public void TrimStart(char c)
+    {
+        var start = 0;
+        while (start < bufferPosition && buffer[start] == c)
+        {
+            start++;
+        }
+
+        if (start > 0)
+        {
+            var newLength = bufferPosition - start;
+            buffer.Slice(start, bufferPosition).CopyTo(buffer);
+            bufferPosition = newLength;
+        }
+    }
+
     /// <summary>
     /// Removes a set of whitespace characters from the ending of this string.
     /// </summary>
@@ -66,4 +116,20 @@ public void TrimEnd()
 
         bufferPosition = end + 1;
     }
+
+    /// <summary>
+    /// Removes the specified character from the end of this string.
+    /// </summary>
+    /// <param name="c">The character to remove.</param>
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
+    public void TrimEnd(char c)
+    {
+        var end = bufferPosition - 1;
+        while (end >= 0 && buffer[end] == c)
+        {
+            end--;
+        }
+
+        bufferPosition = end + 1;
+    }
 }

tests/LinkDotNet.StringBuilder.UnitTests/ValueStringBuilder.Trim.Tests.cs

@@ -46,4 +46,37 @@ public void GivenStringWithWhitespaces_WhenTrim_ThenShouldRemoveWhitespaces(stri
 
         valueStringBuilder.ToString().Should().Be(expected);
     }
+
+    [Fact]
+    public void GivenString_WhenTrimStartCharacter_ThenShouldRemoveCharacter()
+    {
+        using var valueStringBuilder = new ValueStringBuilder();
+        valueStringBuilder.Append("HHeeHH");
+
+        valueStringBuilder.TrimStart('H');
+
+        valueStringBuilder.ToString().Should().Be("eeHH");
+    }
+
+    [Fact]
+    public void GivenString_WhenTrimEndCharacter_ThenShouldRemoveCharacter()
+    {
+        using var valueStringBuilder = new ValueStringBuilder();
+        valueStringBuilder.Append("HHeeHH");
+
+        valueStringBuilder.TrimEnd('H');
+
+        valueStringBuilder.ToString().Should().Be("HHee");
+    }
+
+    [Fact]
+    public void GivenString_WhenTrimCharacter_ThenShouldRemoveCharacter()
+    {
+        using var valueStringBuilder = new ValueStringBuilder();
+        valueStringBuilder.Append("HHeeHH");
+
+        valueStringBuilder.Trim('H');
+
+        valueStringBuilder.ToString().Should().Be("ee");
+    }
 }