Skip to content

[Issue] Fixed conflicting styles for product image container in different listings at the same page #31526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks
m2-assistant bot opened this issue Jan 4, 2021 · 12 comments · May be fixed by #39792
Open
2 tasks

[Issue] Fixed conflicting styles for product image container in different listings at the same page #31526

m2-assistant bot opened this issue Jan 4, 2021 · 12 comments · May be fixed by #39792
Assignees
@Sathakathulla-S
Labels
Area: Product Component: Catalog Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jan 4, 2021 •
edited by github-jira-sync-bot
Loading

This issue is automatically created based on existing pull request: #31473: Fixed conflicting styles for product image container in different listings at the same page

Description (*)

This pull requests solves problem when there are two product listing blocks on the same page. Both blocks have at list one common product. And listings have different image sizes for product image.

Related Pull Requests

Can't find related pull requests.

Fixed Issues (if relevant)

Can't find related issue.

Manual testing scenarios (*)

  1. Open product "Crown Summit Backpack" (SKU 24-MB03) to assign up-sell products. Add at list one up-sell product. One of the assigned products must be "Fusion Backpack" (SKU 24-MB02). Save changes.
  2. Create widget "Catalog Product List" via Magento Admin. Assign widget to store view you test. Layout updates settings: display on "Specified page"; page "Catalog Product View"; container "Main Content Top". Widget Options - select at least two product via SKU. One of products must be "Fusion Backpack" (SKU 24-MB02). Save widget.
  3. Clear Magento 2 cache.
  4. Open product page for "Crown Summit Backpack" (SKU 24-MB03) at store front.

image

With old code you can see that "Fusion Backpack" has smaller image than it should.

This pull request fixes it. "Fusion Backpack" will get same size as "Affirm Water Bottle".

Questions or comments

Contribution checklist (*)

  • < ] Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • [ > All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Catalog Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jan 4, 2021
@m2-assistant m2-assistant bot mentioned this issue Jan 4, 2021
Closed
6 tasks
@krishprakash krishprakash self-assigned this Jan 5, 2021
@m2-assistant
Copy link
Author

m2-assistant bot commented Jan 5, 2021

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash
Copy link

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @krishprakash. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @krishprakash, here is your Magento Instance: https://8de293981e463ae8716370d6ed5a1e60-2-4-develop.instances.magento-community.engineering
Admin access: https://8de293981e463ae8716370d6ed5a1e60-2-4-develop.instances.magento-community.engineering/admin_f342
Login: c0fd3d4a
Password: 6595c0c9b47b

@krishprakash krishprakash added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jan 6, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-40310 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Alfa engcom-Alfa added Area: Content Area: Product Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Area: Content Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 22, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-2909 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Apr 22, 2022

✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-assistant m2-assistant bot mentioned this issue Apr 26, 2022
Closed
5 tasks
@engcom-Hotel engcom-Hotel moved this to Ready for Development in High Priority Backlog Aug 19, 2024
@Sathakathulla-S
Copy link

@magento I'm working on this

@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Apr 7, 2025

Hi @Sathakathulla-S! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@Sathakathulla-S
Copy link

@magento add to contributors team

@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Apr 7, 2025

Hi @Sathakathulla-S! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@Sathakathulla-S
Copy link

@magento I'm working on this

@Sathakathulla-S Sathakathulla-S linked a pull request Apr 7, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sathakathulla-S Sathakathulla-S

Labels
Area: Product Component: Catalog Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
5 participants
@magento-engcom-team @krishprakash @engcom-Alfa @github-jira-sync-bot @Sathakathulla-S