Skip to content

[UX] [RB] Duplicate class #17518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Ducasse opened this issue Dec 13, 2024 · 2 comments · May be fixed by #17941
Open

[UX] [RB] Duplicate class #17518

Ducasse opened this issue Dec 13, 2024 · 2 comments · May be fixed by #17941
Assignees
@AlexisCnockaert
Labels
Project: Refactorings Type: Bug Type: UX

Comments

@Ducasse
Copy link
Member

Ducasse commented Dec 13, 2024 •
edited
Loading

  • Define the classes
TestCase << #RefactoredDepthCalculatorVisitorTest
	slots: {};
	package: 'Champollion2'

TestCase << #Refactored2DepthCalculatorVisitorTest
	slots: {};
	package: 'Champollion2'
  • select RefactoredDepthCalculatorVisitorTest and duplicate class and enter Refactored2DepthCalculatorVisitorTest
  • you get
    Capture 2024-12-13 at 20 36 15
    Capture 2024-12-13 at 20 35 56
@Ducasse
Copy link
Member Author

Ducasse commented Dec 13, 2024

Is should say that the class already exists.

@Ducasse Ducasse changed the title Duplicate class [UX] [RB] Duplicate class Dec 17, 2024
@jecisc
Copy link
Member

jecisc commented Mar 5, 2025

@AlexisCnockaert I think this issue can fit the improvement of the UX

@AlexisCnockaert AlexisCnockaert mentioned this issue Mar 6, 2025
Closed
AlexisCnockaert added a commit to AlexisCnockaert/pharo that referenced this issue Mar 7, 2025
@AlexisCnockaert
Fixed the duplicate class wrong message
73372a4 
Fixes pharo-project#17518
- Indeed there is a  <1?:not > in #isGlobal: in: that was putting a "not" in the linked issue but because we evaluated 	```(RBCondition alreadyExistGlobal: className in: self model) not.``` the not was put in the wrong cases
- I created a new method to handle it to not change anything in #isGlobal: in: to not break something
@AlexisCnockaert AlexisCnockaert linked a pull request Mar 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexisCnockaert AlexisCnockaert

Labels
Project: Refactorings Type: Bug Type: UX
Projects
None yet
Milestone
No milestone
3 participants
@Ducasse @jecisc @AlexisCnockaert