-
Notifications
You must be signed in to change notification settings - Fork 141
Making all sketches easier to use on mobile #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @ksen0 , I tried some moderations in this example that you have provided like changing the position of object or size of canvas and it seems changing the canvas size in just code example wouldn't be enough, we have to position the object as well to appear in frame (in context to this example only), which gives us the idea that to fix these type issue we can try make the output |
We do something on community sketches that have a fixed canvas size to uniformly scale their ![]() ![]() That code lives here, maybe there's a way to adapt that for other embedded editors on the site? |
Hi @webermayank what do you think about the iframe suggestion from @davepagurek ? It's not as extensive as it could be, but changing the content of individual sketches would be also a ton of work to both execute manually and review (including review for consistency). The iframe idea seems like a good middle ground. |
Sorry for delay, @ksen0 , yes absolutely, changing the code content of each sketches is unnecessary thing to do , i was just placing all the possibility that could resolve this issue on the table. The |
Thanks @webermayank ! Do you want to work on the iframe fix? It would be a nice to have so no particular rush! |
Yes sure @ksen0 , i would love to fix it. Would it be like as the above solution @davepagurek suggested or you wanted any modification ? i'd love to address those if there are any. |
Thanks @webermayank ! I think this solution is an intermediate one and possibly more changes could be done systematically later on, so it would be nice to keep this open as a discussion for ideas. But this part of it seems clearly helpful. Please feel free to work on this and in the PR please use "addresses part of [###] (rather than 'fixes') so the issue is not autoclosed. Thanks so much! EDIT: I've added it to the issue: "Make sure that all sketches in examples, reference, and tutorials uniformly scale their iframe tag to fit the width (assigned to @webermayank)" |
Topic
This issue is an invitation to discuss whether this is a problem - and if so, what should be done about it!
Two screenshots below show what is seen on mobile vs desktop for a sketch that is wider than it is longer (landscape rather than portrait) in the Getting Started tutorial. This means on mobile the sketch does not show the circle that should be there.
Though some sketches are not interactive on mobile (if they require keyboard presses for example), most should be viewable. One fix would be to ensure than on mobile all sketches are square. A more major fix would be to ensure that any interaction that aa sketch requires has both a desktop variant and mobile variant.
Should this extend to tutorials, examples, and references - or every sketch on the website?
Please feel free to jump in with your comments and ideas, but don't start any technical work or PRs just yet 🌱
Improvements
The text was updated successfully, but these errors were encountered: