Fix flush condition

Author: puzpuzpuz

export_test.go

@@ -64,6 +64,10 @@ func Messages(s LineSender) string {
 }
 
 func MsgCount(s LineSender) int {
+	if ps, ok := s.(*pooledSender); ok {
+		hs, _ := ps.wrapped.(*httpLineSender)
+		return hs.MsgCount()
+	}
 	if hs, ok := s.(*httpLineSender); ok {
 		return hs.MsgCount()
 	}

sender_pool.go

@@ -191,7 +191,7 @@ func (p *LineSenderPool) Sender(ctx context.Context) (LineSender, error) {
 func (p *LineSenderPool) free(ctx context.Context, ps *pooledSender) error {
 	var flushErr error
 
-	if ps.dirty {
+	if !ps.dirty {
 		flushErr = ps.Flush(ctx)
 	}
 

sender_pool_test.go

@@ -32,6 +32,7 @@ import (
 	"time"
 
 	"github.com/questdb/go-questdb-client/v3"
+	qdb "github.com/questdb/go-questdb-client/v3"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
@@ -75,7 +76,35 @@ func TestBasicBehavior(t *testing.T) {
 	assert.Same(t, s3, s5)
 }
 
-func TestDoubleReleaseShouldFail(t *testing.T) {
+func TestFlushOnClose(t *testing.T) {
+	ctx := context.Background()
+
+	srv, err := newTestHttpServer(readAndDiscard)
+	assert.NoError(t, err)
+	defer srv.Close()
+
+	p, err := questdb.PoolFromOptions(
+		qdb.WithHttp(),
+		qdb.WithAddress(srv.Addr()),
+		qdb.WithAutoFlushDisabled(),
+	)
+	assert.NoError(t, err)
+	defer p.Close(ctx)
+
+	s, err := p.Sender(ctx)
+	assert.NoError(t, err)
+
+	err = s.Table(testTable).StringColumn("bar", "baz").AtNow(ctx)
+	assert.NoError(t, err)
+
+	assert.Equal(t, 1, qdb.MsgCount(s))
+
+	assert.NoError(t, s.Close(ctx))
+
+	assert.Equal(t, 0, qdb.MsgCount(s))
+}
+
+func TestPooledSenderDoubleClose(t *testing.T) {
 	p, err := questdb.PoolFromConf("http::addr=localhost:1234")
 	require.NoError(t, err)