fix: warning when no id in settings (#24)

tanftw · rilwis · web-flow · commit f7748e59c8b9 · 2024-07-18T10:24:56.000+07:00
* fix: warning when no id in settings

* Shorten code

---------

Co-authored-by: Anh Tran &lt;anhtnt@elightup.com&gt;
diff --git a/src/Base.php b/src/Base.php
@@ -45,8 +45,8 @@ protected function get_types(): array {
 		return [ $this->object_type ];
 	}
 
-	public function get( array $data ): array {
-		return $this->get_values( $data['id'] );
+	public function get( array $object ): array {
+		return empty( $object['id'] ) ? [] : $this->get_values( $object['id'] );
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,8 @@ protected function get_types(): array {`
`45`	`45`	`return [ $this->object_type ];`
`46`	`46`	`}`
`47`	`47`
`48`		`- public function get( array $data ): array {`
`49`		`- return $this->get_values( $data['id'] );`
	`48`	`+ public function get( array $object ): array {`
	`49`	`+ return empty( $object['id'] ) ? [] : $this->get_values( $object['id'] );`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`/**`