Make auto archiving work #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning true is only needed if the function is used as a callback for a response to a message, which addToArchiveBox isn't used for.
Opening a private session would cause the extension to throw an error.
pirate
requested changes
Apr 15, 2025
Co-authored-by: Nick Sweeting <[email protected]>
'Snapshot' is the term used by the main ArchiveBox codebase. Also replaced some stray commas with semi-colons.
Also made message handling for 'archivebox_add' messages more robust.
pirate
reviewed
Apr 16, 2025
pirate
reviewed
Apr 16, 2025
pirate
reviewed
Apr 16, 2025
pirate
reviewed
Apr 16, 2025
pirate
reviewed
Apr 16, 2025
pirate
reviewed
Apr 16, 2025
pirate
reviewed
Apr 16, 2025
Co-authored-by: Nick Sweeting <[email protected]>
Since popup.js is an injected content script and can't use imports, I couldn't figure out a nice way to reuse the same Snapshot class defined in utils.js. The stopgap solution is duplicating the definition in popup.js. This is cheap and simple, if somewhat clumsy. Maybe worth revisiting soon. Also, we're keeping the name as 'entries' in local storage to keep users' previous snapshots.
Also removed references to unused notes field of a snapshots and removed the default fields being assigned in getCurrentSnapshot.
ArchiveBox expecting a comma-separated string for the tags is an implementation detail we don't need to leak.
This leads to an infinite loop of requesting permissions, because when enable_auto_archive is modified, we run configureAutoArchiving again. If the permission is not granted, config-tab.js already handles setting enable_auto_archive to false, so this is ultimately unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the auto-archiving regex fields in the configuration page functional.
If the user has enabled auto-archiving, granted the requested permissions, and entered a regex, upon navigating to a new tab, a page with a matching URL (that doesn't match the exclude regex) will be automatically sent to the ArchiveBox server for archiving.
Also, the addToArchiveBox function is simplified while maintaining the same logic, and it looked like syncToArchiveBox was extraneous and didn't handle the fallback logic if the user was using an older version of ArchiveBox, so it was removed.