Skip to content

[SCVMM] Adding cli support for latest API version[2025-03-13]. #8643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kartikverma020
Copy link


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Hi @kartikverma020,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

azure-client-tools-bot-prd bot commented Apr 9, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️scvmm
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd scvmm vm create cmd scvmm vm create added parameter admin_username
⚠️ 1006 - ParaAdd scvmm vm create cmd scvmm vm create added parameter computer_name
⚠️ 1006 - ParaAdd scvmm vm create cmd scvmm vm create added parameter domain_name
⚠️ 1006 - ParaAdd scvmm vm create cmd scvmm vm create added parameter domain_password
⚠️ 1006 - ParaAdd scvmm vm create cmd scvmm vm create added parameter domain_username
⚠️ 1006 - ParaAdd scvmm vm create cmd scvmm vm create added parameter product_key
⚠️ 1006 - ParaAdd scvmm vm create cmd scvmm vm create added parameter run_once_commands
⚠️ 1006 - ParaAdd scvmm vm create cmd scvmm vm create added parameter timezone
⚠️ 1006 - ParaAdd scvmm vm create cmd scvmm vm create added parameter workgroup
⚠️ 1006 - ParaAdd scvmm vm guest-agent enable cmd scvmm vm guest-agent enable added parameter private_link_scope_resource_id

Copy link

github-actions bot commented Apr 9, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 9, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Added new version 1.1.3 in history.rst and setup.py
Copy link

github-actions bot commented Apr 9, 2025

Adding guest os properties in create vm and private link scope resource id in enable guest agent.
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Apr 9, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Apr 9, 2025
@yonzhan yonzhan requested review from kairu-ms and jsntcy April 9, 2025 14:03
@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants