add aks core extensions cli commands #8665
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks extension | sub group aks extension added |
||
| aks extension-type | sub group aks extension-type added |
|
Hi @sophsoph321, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd,
yonzhan and
FumingZhang
|
Hi @sophsoph321 Release SuggestionsModule: aks-preview
Notes
|
…com/sophsoph321/azure-cli-extensions into sophiezhao/coreExtensions
…com/sophsoph321/azure-cli-extensions into sophiezhao/coreExtensions
…com/sophsoph321/azure-cli-extensions into sophiezhao/coreExtensions
| table_transformer=k8s_extension_type_show_table_format | ||
| ) | ||
| g.custom_command( | ||
| 'list-versions-by-location', |
There was a problem hiding this comment.
as mentioned above, can we make this az extension type version list which takes an optional --location or --cluster parameter? If --location parameter specified, you get the list-by-locations experience, same with --cluster.
Same for extension type list.
It just reduces the number of commands and instead uses optional arguments, which seems cleaner. (IMO you should do this in the az extension CLI too, but that's up to you guys)
| ): | ||
| if not check_if_extension_type_is_in_allow_list(extension_type.lower()): | ||
| raise ValidationError(f"Failed to install {extension_type.lower()}" + | ||
| "as it is not in allowed list of extension types") |
|
As discussed in the chat, please ensure that Backup and Flux meet the core extension criteria before allowlist them. |
Implementation details can be found here: https://microsoft-my.sharepoint.com/:w:/p/sophiezhao/EePSiywVdE1NpnA53AI6JfgBNJQZ0pVqmKswIaxZ514zag?e=lgblFt
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
added commands:
az aks extension create
az aks extension update
az aks extension list
az aks extension delete
az aks extension show
az aks extension type list-by-location
az aks extension type show-by-location
az aks extension type list-versions-by-location
az aks extension type show-version-by-location
az aks extension type list-by-cluster
az aks extension type show-by-cluster
az aks extension type list-versions-by-cluster
az aks extension type show-version-by-cluster
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.