update generated code, add connections + indexes #49476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sophia-ramsey
commented
Apr 17, 2025
sophia-ramsey
commented
- update generated code based on commit: 1a7c4e8c06b6727eec8fe97795e0c990e8910044
- add samples folder for Datasets sample
- add connections and indexes samples (still waiting for service side functionality)
sophia-ramsey
requested review from
trangevi,
dargilco,
jhakulin,
glharper and
nick863
as code owners
…ure/azure-sdk-for-net into sramsey/datasets-deployments-onedp
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
jhakulin
reviewed
Apr 18, 2025
| { | ||
| throw new InvalidOperationException("Invalid blob reference for consumption."); | ||
| } | ||
| //if (pendingUploadResponse.Value.BlobReferenceForConsumption == null || |
jhakulin
reviewed
Apr 18, 2025
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| //using System; | ||
| //using System.Collections.Generic; |
jhakulin
reviewed
Apr 18, 2025
| @@ -0,0 +1 @@ | |||
| This is sample file 5 | |||
There was a problem hiding this comment.
Do we need so many sample_file1-8.txt?
There was a problem hiding this comment.
The sample is testing file uploads for nested folders, since we had to write custom upload file and upload folder functions.
jhakulin
reviewed
Apr 18, 2025
| } | ||
| } | ||
| } | ||
| //#nullable disable |
There was a problem hiding this comment.
We shall remove Agents custom code from https://github.com/Azure/azure-sdk-for-net/tree/feature/azure-ai-projects-1dp, which means you can remove all Agents custom code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.