Skip to content

Removed additional forward slash causing 404 error #49496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

james-gould
Copy link

@james-gould james-gould commented Apr 20, 2025

The additional / in both restore API calls results in the URL being:

  • https://{vaultName}.vault.azure.net/certificates//restore
  • https://{vaultName}.vault.azure.net/keys//restore

Removing the additional / constructs a correct path for the request.

For context: I'm building the Azure Key Vault Emulator and have hit this in both keys and certificates, the SecretsClient has the correct path and works without a problem. I raised this a few days in my repo when I found the bug in the KeysClient, having just repeated it in the CertificatesClient I've dug further and got it reproducing. Emulator issue here: james-gould/azure-keyvault-emulator#89

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. KeyVault labels Apr 20, 2025
Copy link

Thank you for your contribution @james-gould! We will review the pull request and get back to you soon.

@james-gould
Copy link
Author

@microsoft-github-policy-service agree

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@james-gould
Copy link
Author

Build failures are due to the request and recorded URL being different (which is the change), please advise on next steps?

@jsquire
Copy link
Member

jsquire commented Apr 20, 2025

Hi @james-gould. Thank you for your contribution and interest in improving the Azure developer experience. The test failures do look to be related to test recordings and would require re-recording. Steps for doing so can be found in the recording section of the test framework README.

@jsquire
Copy link
Member

jsquire commented Apr 20, 2025

@jorgerangel-msft: I'm going to kick the live tests. Can you please take a look at the results and advise whether there's a gap in live testing coverage or in the scenario that is causing a 404 for @james-gould?

@jsquire
Copy link
Member

jsquire commented Apr 20, 2025

/azp run net - keyvault - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@james-gould
Copy link
Author

Sure, will wait for the tests to run. Thanks for getting back so quickly!

@james-gould
Copy link
Author

Will take a little time to record the tests again, need to set everything up locally. Will update the PR when it's ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. KeyVault
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

3 participants