-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Removed additional forward slash causing 404 error #49496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for your contribution @james-gould! We will review the pull request and get back to you soon. |
@microsoft-github-policy-service agree |
API change check API changes are not detected in this pull request. |
Build failures are due to the request and recorded URL being different (which is the change), please advise on next steps? |
Hi @james-gould. Thank you for your contribution and interest in improving the Azure developer experience. The test failures do look to be related to test recordings and would require re-recording. Steps for doing so can be found in the recording section of the test framework README. |
@jorgerangel-msft: I'm going to kick the live tests. Can you please take a look at the results and advise whether there's a gap in live testing coverage or in the scenario that is causing a 404 for @james-gould? |
/azp run net - keyvault - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Sure, will wait for the tests to run. Thanks for getting back so quickly! |
Will take a little time to record the tests again, need to set everything up locally. Will update the PR when it's ready! |
The additional
/
in bothrestore
API calls results in the URL being:https://{vaultName}.vault.azure.net/certificates//restore
https://{vaultName}.vault.azure.net/keys//restore
Removing the additional
/
constructs a correct path for the request.For context: I'm building the Azure Key Vault Emulator and have hit this in both
keys
andcertificates
, theSecretsClient
has the correct path and works without a problem. I raised this a few days in my repo when I found the bug in theKeysClient
, having just repeated it in theCertificatesClient
I've dug further and got it reproducing. Emulator issue here: james-gould/azure-keyvault-emulator#89