Skip to content

Added a button to navigate back to the main CV website(Solves #229) #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Saahi30
Copy link

@Saahi30 Saahi30 commented Feb 1, 2025

Solves the following Issue:-
Add Navigation Button from Blog to Main Site #229

These changes will:
Override the default header template to add a "Go to Circuitverse" button next to the existing "Contact" button
Style the button to match the existing UI/UX of the blog site
Link the button to the main CircuitVerse site (https://circuitverse.org)
The button will be visible on all pages of the blog and will provide an easy way for users to navigate back to the main site. The styling matches the existing theme while maintaining consistency with CircuitVerse's design language.

Before(No button to go back to main website (https://circuitverse.org) )

Screenshot 2025-02-08 at 3 15 55 AM

After:

Screen.Recording.2025-02-08.at.3.19.22.AM.mov

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

alt="{{ .Site.Title }}"
/>
</a>
<button
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

</ul>
{{ if .Site.Params.search.enable }} {{ "<!-- search -->" | safeHTML }}
<div class="search">
<button id="searchOpen" class="search-btn">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

placeholder="Type & Hit Enter..."
/>
</form>
<button id="searchClose" class="search-close">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

@Saahi30
Copy link
Author

Saahi30 commented Feb 7, 2025

@tachyons kindly review

@tachyons
Copy link
Member

tachyons commented Feb 7, 2025

Please add before and after screenshot

<!-- CircuitVerse Button -->
<li class="nav-item">
<a href="https://circuitverse.org" class="nav-link" target="_blank" rel="noopener">
Go to CircuitVerse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text is a bit odd. Could think of a better link ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon me if I am interpreting it wrong but are u referring to the" Go to CircuitVerse" text, if thats the case....sure we can modify it...I have thought of some alternatives like...CircuitVerse ,Simulator, Main Website....

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S I have updated the comment to add before and after screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants