Skip to content

[CWS] Bump security agent policies to v0.66.1 #36436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

YoannGh
Copy link
Contributor

@YoannGh YoannGh commented Apr 24, 2025

What does this PR do?

Backport the changes from #36435 to the 7.66.x branch

The policy changes include minor rule fixes. Diff.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@YoannGh YoannGh requested review from a team as code owners April 24, 2025 15:11
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Apr 24, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 57743915bc9c36d1d439c78336c47f1676814d98

Size reduction summary
package diff status size ancestor threshold
datadog-iot-agent-x86_64-rpm -0.00MB 60.89MB 60.89MB 0.50MB
datadog-iot-agent-x86_64-suse -0.00MB 60.89MB 60.89MB 0.50MB
datadog-iot-agent-aarch64-rpm -0.00MB 58.19MB 58.19MB 0.50MB
Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.04MB ⚠️ 805.63MB 805.59MB 0.50MB
datadog-agent-x86_64-suse 0.04MB ⚠️ 805.63MB 805.59MB 0.50MB
datadog-agent-amd64-deb 0.04MB ⚠️ 796.69MB 796.65MB 0.50MB
datadog-heroku-agent-amd64-deb 0.03MB ⚠️ 440.71MB 440.68MB 0.50MB
datadog-agent-aarch64-rpm 0.02MB ⚠️ 795.48MB 795.46MB 0.50MB
datadog-agent-arm64-deb 0.02MB ⚠️ 786.56MB 786.54MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 31.26MB 31.26MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 30.09MB 30.09MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 31.34MB 31.34MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 31.34MB 31.34MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 60.82MB 60.82MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 58.12MB 58.12MB 0.50MB

Decision

⚠️ Warning

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d87699c2-0532-4921-bf12-12a84da709e9

Baseline: b6c2e2f
Comparison: 8b36a08
Diff

❌ Experiments with missing or malformed data

This is a critical error. No usable optimization goal data was produced by the listed experiments. This may be a result of misconfiguration. Ping #single-machine-performance and we can help out.

  • ddot_traces (Logs)

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_traces memory utilization +2.53 [+2.26, +2.81] 1 Logs
ddot_metrics memory utilization +0.13 [+0.08, +0.18] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.11 [-0.78, +1.00] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.10 [-0.72, +0.92] 1 Logs
otlp_ingest_metrics memory utilization +0.10 [-0.06, +0.25] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.07 [-0.74, +0.88] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.05 [-0.83, +0.93] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.04 [-0.82, +0.90] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.83, +0.88] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.02 [-0.20, +0.23] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.29, +0.30] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.00 [-0.77, +0.77] 1 Logs
quality_gate_idle memory utilization -0.06 [-0.12, -0.00] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput -0.07 [-0.88, +0.74] 1 Logs
otlp_ingest_logs memory utilization -0.18 [-0.33, -0.02] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.19 [-0.23, -0.16] 1 Logs
ddot_logs memory utilization -0.24 [-0.29, -0.19] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.37 [-0.43, -0.30] 1 Logs
file_tree memory utilization -0.77 [-0.94, -0.61] 1 Logs
quality_gate_idle_all_features memory utilization -0.92 [-1.03, -0.80] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -2.20 [-4.94, +0.55] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 770.6 MiB 778.06 MiB 188.75 MiB 191.06 MiB
static_quality_gate_agent_deb_amd64_fips 768.5 MiB 776.09 MiB 187.14 MiB 190.72 MiB
static_quality_gate_agent_heroku_amd64 428.43 MiB 434.99 MiB 112.73 MiB 114.34 MiB
static_quality_gate_agent_msi 958.61 MiB 978.45 MiB 148.1 MiB 151.65 MiB
static_quality_gate_agent_rpm_amd64 770.6 MiB 778.06 MiB 189.42 MiB 193.42 MiB
static_quality_gate_agent_rpm_amd64_fips 768.51 MiB 776.06 MiB 189.07 MiB 192.61 MiB
static_quality_gate_agent_rpm_arm64 760.9 MiB 768.33 MiB 172.21 MiB 174.71 MiB
static_quality_gate_agent_rpm_arm64_fips 759.03 MiB 766.55 MiB 171.15 MiB 173.92 MiB
static_quality_gate_agent_suse_amd64 770.6 MiB 778.08 MiB 189.42 MiB 193.42 MiB
static_quality_gate_agent_suse_amd64_fips 768.5 MiB 776.11 MiB 189.07 MiB 192.78 MiB
static_quality_gate_agent_suse_arm64 760.91 MiB 768.31 MiB 172.21 MiB 174.71 MiB
static_quality_gate_agent_suse_arm64_fips 759.02 MiB 766.5 MiB 171.15 MiB 173.92 MiB
static_quality_gate_docker_agent_amd64 855.09 MiB 862.5 MiB 287.84 MiB 292.0 MiB
static_quality_gate_docker_agent_arm64 868.7 MiB 876.0 MiB 274.43 MiB 278.3 MiB
static_quality_gate_docker_agent_jmx_amd64 855.09 MiB 862.5 MiB 287.84 MiB 292.0 MiB
static_quality_gate_docker_agent_jmx_arm64 868.7 MiB 876.63 MiB 274.43 MiB 278.4 MiB
static_quality_gate_docker_agent_windows1809 855.09 MiB 862.5 MiB 287.84 MiB 292.0 MiB
static_quality_gate_docker_agent_windows1809_core 855.09 MiB 862.5 MiB 287.84 MiB 292.0 MiB
static_quality_gate_docker_agent_windows1809_core_jmx 855.09 MiB 862.5 MiB 287.84 MiB 292.0 MiB
static_quality_gate_docker_agent_windows1809_jmx 855.09 MiB 862.5 MiB 287.84 MiB 292.0 MiB
static_quality_gate_docker_agent_windows2022 855.09 MiB 862.5 MiB 287.84 MiB 292.0 MiB
static_quality_gate_docker_agent_windows2022_core 855.09 MiB 862.5 MiB 287.84 MiB 292.0 MiB
static_quality_gate_docker_agent_windows2022_core_jmx 855.09 MiB 862.5 MiB 287.84 MiB 292.0 MiB
static_quality_gate_docker_agent_windows2022_jmx 855.09 MiB 862.5 MiB 287.84 MiB 292.0 MiB
static_quality_gate_docker_cluster_agent_amd64 262.74 MiB 263.4 MiB 103.32 MiB 104.07 MiB
static_quality_gate_docker_cluster_agent_arm64 278.68 MiB 279.38 MiB 98.18 MiB 98.95 MiB
static_quality_gate_docker_cws_instrumentation_amd64 6.65 MiB 7.12 MiB 2.82 MiB 3.29 MiB
static_quality_gate_docker_cws_instrumentation_arm64 6.44 MiB 6.92 MiB 2.6 MiB 3.07 MiB
static_quality_gate_docker_dogstatsd_amd64 38.03 MiB 46.39 MiB 14.67 MiB 17.78 MiB
static_quality_gate_docker_dogstatsd_arm64 36.94 MiB 45.05 MiB 13.75 MiB 16.65 MiB
static_quality_gate_dogstatsd_deb_amd64 29.89 MiB 38.4 MiB 7.91 MiB 10.26 MiB
static_quality_gate_dogstatsd_deb_arm64 28.77 MiB 36.98 MiB 6.89 MiB 8.96 MiB
static_quality_gate_dogstatsd_rpm_amd64 29.89 MiB 38.4 MiB 7.92 MiB 10.27 MiB
static_quality_gate_dogstatsd_suse_amd64 29.89 MiB 38.4 MiB 7.92 MiB 10.27 MiB
static_quality_gate_iot_agent_deb_amd64 58.08 MiB 58.51 MiB 14.61 MiB 15.02 MiB
static_quality_gate_iot_agent_deb_arm64 55.51 MiB 55.94 MiB 12.62 MiB 13.05 MiB
static_quality_gate_iot_agent_deb_armhf 54.21 MiB 54.32 MiB 12.62 MiB 13.05 MiB
static_quality_gate_iot_agent_rpm_amd64 58.08 MiB 58.51 MiB 14.63 MiB 15.04 MiB
static_quality_gate_iot_agent_rpm_arm64 55.51 MiB 55.94 MiB 12.65 MiB 13.07 MiB
static_quality_gate_iot_agent_suse_amd64 58.08 MiB 58.51 MiB 14.63 MiB 15.04 MiB

@kacper-murzyn
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 25, 2025

View all feedbacks in Devflow UI.

2025-04-25 08:55:03 UTC ℹ️ Start processing command /merge


2025-04-25 08:55:12 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in 7.66.x is approximately 33m (p90).


2025-04-25 09:30:33 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit d0ff67f into 7.66.x Apr 25, 2025
408 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yoanngh/backport-bump-secagent-policies-66-7 branch April 25, 2025 09:30
@github-actions github-actions bot added this to the 7.66.0 milestone Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport category/release_operations changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants