[AI-5206] DDS: WatchGuard Firebox Integration v1.0.0 #20030
+12,788
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datadog-agent-integrations-bot
bot
added
documentation
dev/testing
dev/tooling
release
qa/skip-qa
manan-crest
changed the title
buraizu
added
the
editorial review
|
Created DOCS-10585 for documentation team review |
NouemanKHAL
previously approved these changes
Apr 10, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
|
I think the CODEOWNERS file should be updated to reflect the ownership of this integration. |
temporal-github-worker-1
bot
dismissed
NouemanKHAL’s stale review
Review from NouemanKHAL is dismissed. Related teams and files:
- agent-integrations
- .github/CODEOWNERS
temporal-github-worker-1
bot
added
agent/review-requested
and removed
agent/approved
labels
We have updated CODEOWNERS file. |
jhgilbert
reviewed
Apr 14, 2025
watchguard_firebox/assets/dashboards/watchguard_firebox_proxy_policy.json
Outdated
Show resolved
Hide resolved
watchguard_firebox/assets/dashboards/watchguard_firebox_vpn.json
Outdated
Show resolved
Hide resolved
watchguard_firebox/assets/dashboards/watchguard_firebox_firewall.json
Outdated
Show resolved
Hide resolved
NouemanKHAL
reviewed
Apr 22, 2025
| /watchguard_firebox/ @DataDog/agent-integrations | ||
| /watchguard_firebox/*.md @DataDog/agent-integrations @DataDog/documentation | ||
| /watchguard_firebox/manifest.json @DataDog/agent-integrations @DataDog/documentation | ||
| /watchguard_firebox/assets/logs/ @DataDog/agent-integrations @DataDog/documentation @DataDog/logs-backend @DataDog/logs-core |
There was a problem hiding this comment.
Suggested change
| /watchguard_firebox/assets/logs/ @DataDog/agent-integrations @DataDog/documentation @DataDog/logs-backend @DataDog/logs-core | |
| /watchguard_firebox/assets/logs/ @DataDog/agent-integrations @DataDog/documentation @DataDog/logs-backend @DataDog/logs-integrations-reviewers |
I think log integrations review are handled by @DataDog/logs-integrations-reviewers instead of @DataDog/logs-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR for a new integration WatchGuard Integration 1.0.0
Additional Notes
-- OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository .
-- Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current datadog behavior.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged