This repository was archived by the owner on Jul 2, 2022. It is now read-only.
Add Tuparg - semi-typesafe fast variadic argument iteration support #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the situation of the draft? |
| @@ -0,0 +1,19 @@ | |||
| #include <Printf.hpp> | |||
|
|
|||
| #include <random> | |||
There was a problem hiding this comment.
You should checkout hsd::random
There was a problem hiding this comment.
I know, but hsd doesn't have random_device
|
TODO: Typecheck individual types for |
| @@ -10,7 +10,7 @@ namespace hsd { | |||
| void* addr; | |||
|
|
|||
| template <typename X> | |||
| X& getnext() { | |||
| X& getnext_unsafe() { | |||
| assert(addr); | |||
There was a problem hiding this comment.
What happens if addr is nullptr that you really need to use an assert?
There was a problem hiding this comment.
It's more of a safety measure. The program normally shouldn't allow this function to be called with null pointer, but if it gets called (by some other way than getnext), then it's a debugging check, and it should be erased when compiling for release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Work in progresss