-
-
Notifications
You must be signed in to change notification settings - Fork 674
[tests] Enable sys, threads, eventloop cppia tests #11922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
3c654b4
to
55293a3
Compare
This threads test currently works incorrectly in jit mode: haxe/tests/threads/src/cases/TestEvents.hx Lines 35 to 38 in ffd3b45
This is because local functions break exceptions in jit mode, see: HaxeFoundation/hxcpp#876 (comment) |
The hxcpp PR has been merged, please update the branch. |
55293a3
to
9b9cff2
Compare
There are still cppia jit failures. I think it is due to: HaxeFoundation/hxcpp#1212, but it's strange that it isn't affecting Linux because the minimal sample does. |
I've found that on linux there is an element of randomness, the same code can cause the issue or not depending on where it is found in the program and whether the client script was compiled with I think the problem is that there is some out of bounds memory access occurring due to the attempt to run a method on a null object, and in some cases this out of bounds access is not detected on Linux, but is always detected on Windows and Mac. Either way, the hxcpp patch includes some additional tests and fixes these errors. |
There were failures due to: HaxeFoundation/hxcpp#901. I've added workarounds for now to avoid the errors.