-
Notifications
You must be signed in to change notification settings - Fork 156
Jart synapse #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZhenmingYu
wants to merge
86
commits into
IBM:master
Choose a base branch
from
PGI15:jart-synapse
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Jart synapse #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old dev code with v0.5.1
Closed
Hi @ZhenmingYu, It looks like you have a linking error and the following de-mangled symbol is not being found: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Support a new device type based on JART V1b memristor model and test scripts for that.
Details can be found at https://ieeexplore.ieee.org/document/10052010
Fixing the issues in #583 and #679 about building errors
Description
Deleted CUDA related codes, fixed JART CPU version.
Still not able to run properly, issues relates to device.py and the linkage between python and c++ code.
Details
My original implementation was with the BUILD_PULSED_DEVICE_CONSTRUCTORS (commented out on line 540).
@maljoras changed it to the current implementation because he thinks some parts are not necessary for my device as I remembered.
I don't really have a good understanding of this section about managing the parameters and how they go in and out of the memory, so I'm not comfortable about changing stuff here.
However, by comparing with the BUILD_PULSED_DEVICE_CONSTRUCTORS, it seems that a "public:" was missing at line 266?
And adding that seems to have solved the compilation issue.
I don't really know the code here is correct or whether there are any problems.
But anyhow the examples are still not running yet, which means some part between the python-c++ linkage is still not correct.
My current error output:
(.venv) zyu@pgi15-gpu2:~/aihwkit$ python examples/03_mnist_training.py
Traceback (most recent call last):
File "/Users/zyu/aihwkit/examples/03_mnist_training.py", line 27, in
from aihwkit.nn import AnalogLinear, AnalogSequential
File "/Users/zyu/aihwkit/src/aihwkit/nn/init.py", line 11, in
from aihwkit.nn.modules.container import AnalogSequential, AnalogWrapper
File "/Users/zyu/aihwkit/src/aihwkit/nn/modules/container.py", line 17, in
from aihwkit.nn.modules.base import AnalogLayerBase
File "/Users/zyu/aihwkit/src/aihwkit/nn/modules/base.py", line 16, in
from aihwkit.simulator.tiles.module import TileModule
File "/Users/zyu/aihwkit/src/aihwkit/simulator/tiles/init.py", line 11, in
from aihwkit.simulator.tiles.analog import AnalogTile
File "/Users/zyu/aihwkit/src/aihwkit/simulator/tiles/analog.py", line 15, in
from aihwkit.simulator.tiles.rpucuda import RPUCudaSimulatorTileWrapper
File "/Users/zyu/aihwkit/src/aihwkit/simulator/tiles/rpucuda.py", line 18, in
from aihwkit.simulator.parameters.base import RPUConfigGeneric
File "/Users/zyu/aihwkit/src/aihwkit/simulator/parameters/init.py", line 25, in
from .training import UpdateParameters
File "/Users/zyu/aihwkit/src/aihwkit/simulator/parameters/training.py", line 14, in
from .helpers import _PrintableMixin
File "/Users/zyu/aihwkit/src/aihwkit/simulator/parameters/helpers.py", line 14, in
from aihwkit.simulator import rpu_base
ImportError: /Users/zyu/aihwkit/src/aihwkit/simulator/rpu_base.cpython-312-x86_64-linux-gnu.so: undefined symbol: _ZN3RPU29JARTv1bRPUDeviceMetaParameterIfE10initializeEv