Skip to content

Add deaccession reason to version summary #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

ChengShi-1
Copy link
Contributor

What this PR does / why we need it:

the api endpoint added a {deaccession: {reason: string, url: string }} into the version summary, so the model should be changed accordingly to get the deaccession reason

Which issue(s) this PR closes:

Special notes for your reviewer:

@ChengShi-1 ChengShi-1 linked an issue Apr 18, 2025 that may be closed by this pull request
@github-actions github-actions bot added FY25 Sprint 21 FY25 Sprint 21 (2025-04-09 - 2025-04-23) GREI Re-arch GREI re-architecture-related SPA.Q2 Not related to any specific Q2 feature SPA: Dataset View Page labels Apr 18, 2025
@ChengShi-1 ChengShi-1 added Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels Apr 18, 2025
@ChengShi-1 ChengShi-1 marked this pull request as ready for review April 18, 2025 21:14
@ChengShi-1 ChengShi-1 moved this to Ready for Review ⏩ in IQSS Dataverse Project Apr 18, 2025
@g-saracca g-saracca moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Apr 22, 2025
@g-saracca g-saracca self-assigned this Apr 22, 2025
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Apr 22, 2025
@g-saracca g-saracca removed their assignment Apr 22, 2025
@ofahimIQSS
Copy link
Contributor

tests passing, merging PR

@ofahimIQSS ofahimIQSS merged commit edf7b28 into develop Apr 22, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Ready for QA ⏩ to Merged 🚀 in IQSS Dataverse Project Apr 22, 2025
@ofahimIQSS ofahimIQSS deleted the deaccession-reason branch April 22, 2025 13:24
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 21 FY25 Sprint 21 (2025-04-09 - 2025-04-23) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Dataset View Page SPA.Q2 Not related to any specific Q2 feature
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Add deaccessioned reason to DatasetVersionsSummary
3 participants