-
Notifications
You must be signed in to change notification settings - Fork 24
Minor cleanup of internals #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is dependent on ITensor/ITensors.jl#1544, then after that we can plan on a potential ITensorMPS.jl PR to fully disentangle the package (regarding slicing a MPS) |
Can we simplify things and first make a PR here that includes the changes that don't depend on ITensor/ITensors.jl#1544? |
Sure, I clarified the comments but it seems its ready to go (or at least for your review) |
Look good to me, though mostly what I'm going by is that this PR removes code and the tests still pass, so hopefully the tests are comprehensive! |
Can you bump the version and register after merging? |
Seems so, the examples still work and get to the exact energies which is really what I'm basing it off of!
I've bumped to 0.2 and also increased the ITensors to 0.8 |
Thanks @ryanlevy! |
This is the beginning of a small cleanup of some of the internals to match current upstream packages.
Functions labeled
# added
are being included in a upstream PR and to be removed pending proper porting