Skip to content

Minor cleanup of internals #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 18, 2025
Merged

Minor cleanup of internals #91

merged 6 commits into from
Feb 18, 2025

Conversation

ryanlevy
Copy link
Contributor

This is the beginning of a small cleanup of some of the internals to match current upstream packages.

Functions labeled # added are being included in a upstream PR and to be removed pending proper porting

@mtfishman
Copy link
Member

@ryanlevy sorry for the slow response on this, this slipped my mind. I started making a PR to fix #100 which turned out to be similar to this PR, what is needed for this PR to be completed? The changes you've made here look reasonable to me.

@ryanlevy
Copy link
Contributor Author

This is dependent on ITensor/ITensors.jl#1544, then after that we can plan on a potential ITensorMPS.jl PR to fully disentangle the package (regarding slicing a MPS)

@mtfishman
Copy link
Member

Can we simplify things and first make a PR here that includes the changes that don't depend on ITensor/ITensors.jl#1544?

@ryanlevy ryanlevy marked this pull request as ready for review February 18, 2025 01:21
@ryanlevy
Copy link
Contributor Author

Sure, I clarified the comments but it seems its ready to go (or at least for your review)

@mtfishman
Copy link
Member

Look good to me, though mostly what I'm going by is that this PR removes code and the tests still pass, so hopefully the tests are comprehensive!

@mtfishman
Copy link
Member

Can you bump the version and register after merging?

@ryanlevy
Copy link
Contributor Author

Look good to me, though mostly what I'm going by is that this PR removes code and the tests still pass, so hopefully the tests are comprehensive!

Seems so, the examples still work and get to the exact energies which is really what I'm basing it off of!

Can you bump the version and register after merging?

I've bumped to 0.2 and also increased the ITensors to 0.8

@mtfishman mtfishman merged commit 8ae617c into ITensor:main Feb 18, 2025
6 checks passed
@mtfishman
Copy link
Member

Thanks @ryanlevy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants