Add K/Wasm D8 target to the benchmarks #5277

eymar · 2025-04-10T15:21:28Z

Updated the README.md with the description of benchmarks (might be useful to external parties)
customized a runner for D8
added a warmupCount parameter to runBenchmarks, because it's required for Jetstream3 (a set of benchmarks) that there is no warmup (they skip it)
Added a smooth scroll variant of LazyGrid + variants with LaunchedEffect in grid cells for coroutines usage.

Fixes https://youtrack.jetbrains.com/issue/CMP-6942

Note: it's based on this PR #5275

Testing

Manually run the benchmarks

Release Notes

N/A

…rk in preparation for D8 benchmarks D8 environment misses some APIs including a parser of xml. Also, make sure the web targets process the asynchronous fetch resources operations by yielding the event loop. Otherwise, a benchmark would skip a part of the workload.

…dEventLoop function

pjBooms · 2025-04-10T16:14:59Z

benchmarks/multiplatform/benchmarks/src/wasmJsMain/kotlin/main.wasmJs.kt

+    val args = "benchmarks=$benchmarkName($frameCount)"
+    Args.parseArgs(arrayOf(args))
+    Args.enableModes(Mode.SIMPLE)


If you use parseArgs with custom args there is no need to introduce enableModes, you may pass modes to parseArgs

As mentioned in one of the other comments:

I realized that in a case of fun customLaunch(benchmarkName: String, frameCount: Int): Promise<JsAny?> { I'd like to minimize the strings manipulation / string building, to minimize the constant time of the benchmark.

Also it would help with avoiding a bit redundant args string parsing.

pjBooms · 2025-04-11T12:22:06Z

benchmarks/multiplatform/benchmarks/src/commonMain/kotlin/Args.kt

@@ -38,6 +40,8 @@ object Args {
     * with values separated by commas.
     */
    fun parseArgs(args: Array<String>) {
+        // reset the previous configuration before setting a new one for cases when parseArgs is called more than once:
+        reset()


I would call reset explicitly from the places where it is really required.

pjBooms · 2025-04-11T12:23:40Z

benchmarks/multiplatform/benchmarks/src/commonMain/kotlin/Args.kt

@@ -55,12 +59,28 @@ object Args {

    private fun String.decodeArg() = replace("%20", " ")

+    private fun reset() {


Please comment this function providing reasoning when it is required

pjBooms · 2025-04-11T12:31:40Z

benchmarks/multiplatform/benchmarks/src/commonMain/kotlin/benchmarks/lazygrid/LazyGrid.kt

    val itemCount = 12000
    val entries = remember {List(itemCount) { Entry("$it") }}
    val state = rememberLazyGridState()

-    var smoothScroll by remember { mutableStateOf(false)}
+    var scrollIteration by remember { mutableStateOf(0) }


Why do we need this extra state?

So the state.scrollToItem(curItem) won't be cancelled before it completes.

When LaunchedEffect takes curItem as a key it will be cancelled after curItem value changes.

Now, scrollIteration is a new key for LaunchedEffect.

https://developer.android.com/develop/ui/compose/side-effects#launchedeffect

If LaunchedEffect is recomposed with different keys (see the Restarting Effects section below), the existing coroutine will be cancelled and the new suspend function will be launched in a new coroutine.

pjBooms · 2025-04-11T12:34:11Z

benchmarks/multiplatform/benchmarks/src/wasmJsMain/kotlin/main.wasmJs.kt

    val urlParams = URLSearchParams(window.location.search.toJsString())
    var i = 0
    val args = generateSequence { urlParams.get("arg${i++}") }.toList().toTypedArray()
    Args.parseArgs(args)
+
+    Args.enableModes(Mode.SIMPLE)


User can set required modes themselves, I do not think we need to restrict them here without a strong reason (like for D8)

removed Args.enableModes(Mode.SIMPLE) for browser case - fixed.

pjBooms · 2025-04-11T12:38:29Z

benchmarks/multiplatform/benchmarks/src/commonMain/kotlin/Args.kt

+    // Some targets can't support all the benchmarks (e.g. D8) due to limited APIs availability,
+    // so we skip them
+    fun skipBenchmark(benchmark: String) {
+        benchmarksToSkip.add(benchmark.uppercase())


rename to disableBenchmark ?

pjBooms · 2025-04-11T12:42:05Z

benchmarks/multiplatform/benchmarks/src/wasmJsMain/kotlin/main.wasmJs.kt

+        Args.parseArgs(args.split(" ").toTypedArray())
+    }
+    Args.enableModes(Mode.SIMPLE)


Leave a comment why only Simple mode is supported (and again you can pass mode to args)

and again you can pass mode to args

I realized that in a case of fun customLaunch(benchmarkName: String, frameCount: Int): Promise<JsAny?> { I'd like to minimize the strings manipulation / string building, to minimize the constant time of the benchmark.

In this case there is no need to build the args string, because there is only one specific benchmark to run with known frameCount. The mode is also known - it's always SIMPLE for D8 (i'll add the comment to explain why it's the case).

I'll add a new function to Args: fun addBenchmark(name: String, frameCount: Int) so no parsing would be needed.

Let me know what you think

pjBooms · 2025-04-11T12:48:03Z

...ks/multiplatform/benchmarks/src/commonMain/kotlin/benchmarks/animation/AnimatedVisibility.kt

@@ -38,7 +38,7 @@ fun AnimatedVisibility() {
            AnimatedVisibility(showImage) {
                transition = this.transition
                Image(
-                    painterResource(Res.drawable.compose_multiplatform),
+                    painterResource(Res.drawable.img),


I guess compose_multiplatform.xml is not used anymore and can be removed from the resources (and thus we can name png as compose_multiplatform.png).

eymar added 6 commits April 9, 2025 14:53

add D8

d9786fe

customize the runner for D8

fa32a40

Update README.md

05ce4ab

Update README.md

7e7e618

explain the reasoning for a stubbed fun mainD8

52afe66

eymar requested a review from pjBooms April 10, 2025 15:21

get rid of custom EventLoop abstraction in preference of simpler yiel…

100d4e9

…dEventLoop function

eymar mentioned this pull request Apr 11, 2025

Use png image instead of a vector image in AnimatedVisibility benchmark #5275

Closed

pjBooms requested changes Apr 11, 2025

View reviewed changes

pjBooms reviewed Apr 11, 2025

View reviewed changes

code review

db72cf3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add K/Wasm D8 target to the benchmarks #5277

Add K/Wasm D8 target to the benchmarks #5277

eymar commented Apr 10, 2025 •

edited

Loading

pjBooms Apr 10, 2025

eymar Apr 11, 2025

pjBooms Apr 11, 2025

eymar Apr 11, 2025

pjBooms Apr 11, 2025

eymar Apr 11, 2025

pjBooms Apr 11, 2025

eymar Apr 11, 2025 •

edited

Loading

pjBooms Apr 11, 2025

eymar Apr 11, 2025

pjBooms Apr 11, 2025

eymar Apr 11, 2025

pjBooms Apr 11, 2025

eymar Apr 11, 2025

pjBooms Apr 11, 2025

eymar Apr 11, 2025

		@@ -55,12 +59,28 @@ object Args {

		private fun String.decodeArg() = replace("%20", " ")

		private fun reset() {

Add K/Wasm D8 target to the benchmarks #5277

Are you sure you want to change the base?

Add K/Wasm D8 target to the benchmarks #5277

Conversation

eymar commented Apr 10, 2025 • edited Loading

Testing

Release Notes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eymar Apr 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eymar commented Apr 10, 2025 •

edited

Loading

eymar Apr 11, 2025 •

edited

Loading