Skip to content

fix indexing bug in saxpy.py #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2025
Merged

fix indexing bug in saxpy.py #582

merged 4 commits into from
Apr 29, 2025
+1 −1

Conversation

msaroufim
Copy link
Contributor

@msaroufim msaroufim commented Apr 25, 2025 •
edited
Loading

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Apr 25, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@msaroufim
signoff
2e75145 
Signed-off-by: Mark Saroufim <[email protected]>
@leofang leofang self-requested a review April 26, 2025 03:53
@leofang leofang added bug Something isn't working P0 High priority - Must do! cuda.core Everything related to the cuda.core module blocked This task is currently blocked by other tasks example Improvements or additions to code examples labels Apr 26, 2025
@leofang leofang added this to the cuda.core beta 4 milestone Apr 26, 2025
@leofang leofang removed the blocked This task is currently blocked by other tasks label Apr 28, 2025
@leofang
Copy link
Member

leofang commented Apr 29, 2025

/ok to test 4569f2c

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@kkraus14
Copy link
Collaborator

/ok to test dc0481f

@kkraus14 kkraus14 merged commit a3cd5ae into NVIDIA:main Apr 29, 2025
75 checks passed
@github-actions GitHub Actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang
Copy link
Member

leofang commented Apr 29, 2025

@msaroufim thanks for catching my silly mistake! This typo was covered up and went undetected by the CI because we still launch enough blocks to populate the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@leofang leofang Awaiting requested review from leofang

Assignees
No one assigned
Labels
bug Something isn't working cuda.core Everything related to the cuda.core module example Improvements or additions to code examples P0 High priority - Must do!
Projects
None yet
Milestone
cuda.core beta 4
Development

Successfully merging this pull request may close these issues.
3 participants
@msaroufim @leofang @kkraus14