[PATCH v1] linux-dpdk: event: improve event validity checking #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilize rte_mbuf_check() function for event validity checking. Signed-off-by: Matias Elo <[email protected]>
odpbuild
changed the title
| @@ -234,6 +236,11 @@ int _odp_event_is_valid(odp_event_t event) | |||
| if (event_hdr->hdr.index >= pool->rte_mempool->size) | |||
| return 0; | |||
|
|
|||
| if (odp_unlikely(rte_mbuf_check(_odp_event_to_mbuf(event), 1, &reason))) { | |||
There was a problem hiding this comment.
External API so could use the explicit failure return value of -1.
Worth also making the rest of the failure branches odp_unlikely()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilize rte_mbuf_check() function for event validity checking.