Fix issue where annotations are not properly traversed for Python 3.8 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasmysamy
requested review from
feussy,
hintse,
timkpaine and
ptomecek
as code owners
rasmysamy
force-pushed
the
bugfix/adjust_annotations_py38
branch
from
8c2a374 to
9bb6af5
Compare
Signed-off-by: Samy Rasmy <[email protected]>
rasmysamy
force-pushed
the
bugfix/adjust_annotations_py38
branch
from
9bb6af5 to
360d2a6
Compare
ptomecek
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Approved, but note that the aim is to completely remove python 38 support soon as it is EOL. Also worth noting that all of the annotation adjustment stuff should go away once this issue is closed: pydantic/pydantic#9670, because then we can just switch to leveraging the serialize_as_any functionality from pydantic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR properly traverses Python 3.8 annotations to recursively apply
_adjust_annotations, which fixes bugs where Pydantic models are not properly serialized.