chore(preview-middleware):adjust readme #3134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
heimwege
commented
Apr 16, 2025
•
heimwege
commented
- correct some wrong default values
- add default value columns everywhere
- separate value type and requirement type in different columns
- move requirement type from description and former type column to the new requirement type column
- rephrasing some descriptions
🦋 Changeset detectedLatest commit: 5db6a75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lfindlaysap
requested changes
Apr 17, 2025
| | `scp` | `boolean` optional | If set to true the proxy will execute the required OAuth routine for the ABAP environment on SAP BTP | | ||
| | Option | Value Type | Requirement Type | Default Value | Description | | ||
| | ------------- |------------|-----------------------|---------------|-------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `url` | `string` | mandatory (local) | `undefined` | Mandatory URL pointing to the backend system. *Not required if destination is provided and the proxy is running SAP Business Application Studio | |
There was a problem hiding this comment.
Suggested change
| | `url` | `string` | mandatory (local) | `undefined` | Mandatory URL pointing to the backend system. *Not required if destination is provided and the proxy is running SAP Business Application Studio | | |
| | `url` | `string` | mandatory (local) | `undefined` | Mandatory URL pointing to the back-end system. *Not required if destination is provided and the proxy is running SAP Business Application Studio | |
There was a problem hiding this comment.
Is it backend, back-end or back end?
| | Option | Value Type | Requirement Type | Default Value | Description | | ||
| | ------------- |------------|-----------------------|---------------|-------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `url` | `string` | mandatory (local) | `undefined` | Mandatory URL pointing to the backend system. *Not required if destination is provided and the proxy is running SAP Business Application Studio | | ||
| | `destination` | `string` | mandatory (if no url) | `undefined` | Required if the backend system is available as destination in SAP Business Application Studio. | |
There was a problem hiding this comment.
Suggested change
| | `destination` | `string` | mandatory (if no url) | `undefined` | Required if the backend system is available as destination in SAP Business Application Studio. | | |
| | `destination` | `string` | mandatory (if no URL) | `undefined` | Required if the back-end system is available as destination in SAP Business Application Studio. | |
There was a problem hiding this comment.
Is it backend, back-end or back end?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.