feat: Add the Extension Project functionality #3146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 14dea02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
…open-ux-tools into feat/3015/extension-project
lfindlaysap
reviewed
Apr 22, 2025
There was a problem hiding this comment.
@nikmace, could you provide a screenshot of what these new prompts look like on the UI? Thanks.
|
@lfindlaysap Here are the two cases in which the extension project prompts are shown when the application is not supported: |
lfindlaysap
requested changes
Apr 23, 2025
There was a problem hiding this comment.
@nikmace, thanks so much for the screenshots. Here are my suggestions.
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
lfindlaysap
reviewed
Apr 23, 2025
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
|
lfindlaysap
reviewed
Apr 25, 2025
| "appDoesNotSupportAdaptation": "The application that you have selected does not support flexibility. Adaptation projects are only supported with those applications. Please choose an application which supports flexibility.", | ||
| "appDoesNotSupportManifest": "The selected application is not supported by the adaptation project. Please select a different application. For more information, see SAPUI5 Adaptation Project documentation.", | ||
| "extensibilityGenNotFound": "Extensibility Project generator plugin was not found in your dev space, and is required for this action. To proceed, please install the <SAPUI5 Layout Editor & Extensibility> extension.", | ||
| "creatingExtensionProjectError": "Creating Extension Project failed. To see the error, view the logs." |
There was a problem hiding this comment.
Suggested change
| "creatingExtensionProjectError": "Creating Extension Project failed. To see the error, view the logs." | |
| "creatingExtensionProjectError": "Creating the extension project failed. To see the error, view the logs." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat for #3015.
FioriIdandApplication Component Hierarchy(ACH) prompts and writes the answers as descriptor changes tomanifest.appdescr_variantfile for support purposes.i18n.propertiesfile.