add DAETS integrator #2609
Open
add DAETS integrator #2609
+2,174
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tansongchen
changed the title
Comment on lines
+93
to
+95
| ui = make_taylor(uprev, us[1:i]...) | ||
| ti = TaylorScalar{i}(t, one(t)) | ||
| outi = make_taylor(ks[1:i+1]...) |
There was a problem hiding this comment.
For the in place versions, these should be part of the cache and mutated rather than allocating new ones each time.
| dti *= dt | ||
| @.. u += dti * us[i + 1] | ||
| end | ||
| OrdinaryDiffEqCore.increment_nf!(integrator.stats, 3) |
There was a problem hiding this comment.
This should increment by P (or something like that), right?
| @@ -0,0 +1,257 @@ | |||
| # struct Tsit5ConstantCache <: OrdinaryDiffEqConstantCache end | |||
There was a problem hiding this comment.
this file isn't supposed to be here, right?
| @@ -0,0 +1,352 @@ | |||
| RK_WITH_SPECIAL_INTERPOLATIONS = Union{Tsit5ConstantCache, Tsit5Cache} | |||
There was a problem hiding this comment.
all of the stuff here is wrong (we should probably delete the file for now)
| @test Σ[2, 2] == 2 | ||
| end | ||
|
|
||
| println("DONE Signature Matrix Tests") |
There was a problem hiding this comment.
the @testset will do the printing, no need to add printlns manually.
| return nothing | ||
| end | ||
|
|
||
| @muladd function perform_step!(integrator, cache::DAETSCache, repeat_step = false) |
There was a problem hiding this comment.
This is just the ExplicitTaylor2 implimentation? is the DAETS step missing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
see #524
Add any other context about the problem here.