-
Notifications
You must be signed in to change notification settings - Fork 163
[DNM] Generate and store a combined extension schema #5609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: shauns/04-04-output-debug-friendly-schema
Are you sure you want to change the base?
[DNM] Generate and store a combined extension schema #5609
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Unused exports (1)
|
b8bf9d8
to
d98aa8b
Compare
557d371
to
41ee024
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/fs.d.ts@@ -103,13 +103,13 @@ export declare function writeFile(path: string, data: string | Buffer, options?:
*/
export declare function writeFileSync(path: string, data: string): void;
/**
- * Creates a directory at the given path.
+ * Creates a directory at the given path. Directories are created recursively if needed.
*
* @param path - Path to the directory to be created.
*/
export declare function mkdir(path: string): Promise<void>;
/**
- * Synchronously creates a directory at the given path.
+ * Synchronously creates a directory at the given path. Directories are created recursively if needed.
*
* @param path - Path to the directory to be created.
*/
@@ -263,6 +263,13 @@ interface GenerateRandomDirectoryOptions {
* @returns It returns the name of the directory.
*/
export declare function generateRandomNameForSubdirectory(options: GenerateRandomDirectoryOptions): Promise<string>;
+/**
+ * Read the contents of a directory.
+ *
+ * @param path - Path to the directory.
+ * @returns A promise that resolves to an array of the names of the files in the directory.
+ */
+export declare function readdir(path: string): Promise<string[]>;
/**
* Traverse the file system and return pathnames that match the given pattern.
*
|
1 similar comment
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/fs.d.ts@@ -103,13 +103,13 @@ export declare function writeFile(path: string, data: string | Buffer, options?:
*/
export declare function writeFileSync(path: string, data: string): void;
/**
- * Creates a directory at the given path.
+ * Creates a directory at the given path. Directories are created recursively if needed.
*
* @param path - Path to the directory to be created.
*/
export declare function mkdir(path: string): Promise<void>;
/**
- * Synchronously creates a directory at the given path.
+ * Synchronously creates a directory at the given path. Directories are created recursively if needed.
*
* @param path - Path to the directory to be created.
*/
@@ -263,6 +263,13 @@ interface GenerateRandomDirectoryOptions {
* @returns It returns the name of the directory.
*/
export declare function generateRandomNameForSubdirectory(options: GenerateRandomDirectoryOptions): Promise<string>;
+/**
+ * Read the contents of a directory.
+ *
+ * @param path - Path to the directory.
+ * @returns A promise that resolves to an array of the names of the files in the directory.
+ */
+export declare function readdir(path: string): Promise<string[]>;
/**
* Traverse the file system and return pathnames that match the given pattern.
*
|
Coverage report
Test suite run success2182 tests passing in 954 suites. Report generated by 🧪jest coverage report action from 41ee024 |
As downstack, but for extensions.
This produces a good JSON schema for extensions (it only covers UI extensions & functions right now though). But, the most common LSP for TOML will struggle with this schema as it is oriented around a union/anyOf. So as-is, this is a demonstration of what may be possible, but today isn't.