Use a TCP server to listen to streaming test events #3388
+381
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
vscode
Graphite App
vinistock
force-pushed
the
04-08-use_a_tcp_socket_to_stream_test_results
branch
from
4624b86 to
5ddc813
Compare
vinistock
force-pushed
the
04-09-use_a_tcp_server_to_listen_to_streaming_test_events
branch
3 times, most recently
from
b9853dd to
fa4d84d
Compare
vinistock
force-pushed
the
04-08-use_a_tcp_socket_to_stream_test_results
branch
from
5ddc813 to
377a675
Compare
vinistock
force-pushed
the
04-09-use_a_tcp_server_to_listen_to_streaming_test_events
branch
from
f289ddb to
f9d9b4a
Compare
vinistock
force-pushed
the
04-08-use_a_tcp_socket_to_stream_test_results
branch
from
377a675 to
11b16fb
Compare
vinistock
force-pushed
the
04-09-use_a_tcp_server_to_listen_to_streaming_test_events
branch
from
f9d9b4a to
e92b42e
Compare
vinistock
changed the base branch from
04-08-use_a_tcp_socket_to_stream_test_results
to
graphite-base/3388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3359
This PR starts using a TCP server to listen to test events on the extension side. The logic was getting quite complicated, so I made an attempt to extract a
StreamingRunnerclass, which I really hope made the code a bit easier to follow for others.Implementation
In terms of behaviour changes, there isn't much. We use
net.serverto start a TCP server and then we pass the port as an environment variable, so that the server side integration can connect.The rest was just moving stuff into the
StreamingRunnerclass, so that the implementation is a bit more organized.EDIT
I pushed a second commit that makes the TCP server persistent.
This allows us to do some interesting magic for the run in terminal profile. Since the TCP server is always on and we can control the initial terminal creation, even if the user runs tests manually inside the terminal we are still able to update the explorer statuses.
I would really like to hear people's opinion about the organization of the code afterwards.
Automated Tests
Updated our existing tests.