-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Update a_deeper_look_at_git.md #29528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add a tutorial video for git branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to make this suggestion. However, I am unsure why you are removing an in-depth video about rebase + merge and replacing it with one that does not cover this material? Plus, I think the original video has better visuals to understanding different branches. Can you clarify what you did not find helpful in the original video?
In addition, I am not a fan of putting two additional resources in 1 bullet point, so this change would need to be reverted. (Note: the person that gave you this feedback is not a maintainer at TOP).
Oh I am so sorry! I thought the person who gave me feedback is a maintainer. @rlmoser99 |
Can you please have a look if the change I have just applied is valid? Thank you so much! |
If you were referring to my comment about rewording the sentence you wrote that was not an approval of the PR content or an approval to merge the changes. I was making a suggestion on the sentence wording for clarity and acknowledging the video source only. It looks like you left a comment, resolved my comment, did not change the wording, then merged the PR. In the Contributing.md file under Opening a Pull Request, line 3 states "At this point a maintainer will either leave general comments, request changes, or approve and merge your PR." and a little further down it mentions requesting another review after the changes are made. Non-maintainers do not merge PRs, so I would not have approved your PR or given permissions for you to merge it. A maintainer will merge the PR once it is ready is my understanding. Question for @rlmoser99, should non-maintainers review PRs? I thought it was ok because in the node-revamp discord channel it was mentioned that we were welcome to review the PRs for lessons in review. Should I just stick to reviewing the new lessons? |
@ChuqiaoHuang I don't see any changes to what I had already looked at and reviewed. Can you also explain more details about what you did not find helpful in the original video, as I am not keen to replace what was there with the one you proposed? |
@Amiriel01 You are welcome to review PRs. However it would be best if you let people know that you are not part of the maintainer team, because people do not know/see the difference. Even people that are not maintainers often state this when they provide feedback. |
Adding a git branch tutorial video
Because
The a_deeper_look_at_git.md lesson currently lacks a video resource for Git branching. Adding a tutorial video will help learners who prefer visual explanations and enhance their understanding of branching concepts. The selected video provides a clear and concise explanation of Git branching, making it an excellent resource for learners.
This PR
Issue
Closes #XXXXX
Additional Information
NA
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section