feat: analytics events view_item_list, select_item #1703
Conversation
ivan-kalachikov
requested review from
Andrew-Orlov,
goldenmaya and
NaMax66
and removed request for
a team
| @@ -381,26 +385,6 @@ watch( | |||
| }, | |||
| { immediate: true }, | |||
| ); | |||
|
|
|||
| /** | |||
| * Send Google Analytics event for related products. | |||
There was a problem hiding this comment.
moved into the related-products component
| @@ -105,4 +108,9 @@ const { localizedItemsErrors, setErrors } = useErrorsTranslator<ValidationErrorT | |||
| const preparedLineItems = computed(() => prepareLineItems(props.items)); | |||
|
|
|||
| watchEffect(() => setErrors(validationErrors.value)); | |||
|
|
|||
| const handleLinkClick = (item: PreparedLineItemType) => { | |||
| const lineItem = props.items.find((i) => i.id === item.id); | |||
There was a problem hiding this comment.
i looks strange. rename to smth else
|
|
||
| watch( | ||
| relatedProducts, | ||
| () => { |
There was a problem hiding this comment.
let's decide - do we pass parameters to the handler or look outside
| viewItemList: [items: { code: string }[], params?: EventParamsType & ViewItemListParamsAdditionalType]; | ||
| selectItem: [item: Product | LineItemType, params?: EventParamsType]; | ||
| viewItemList: [items: { code: string }[], params?: EventParamsType & ListPropertiesType]; | ||
| selectItem: [item: Product | LineItemType, params?: EventParamsType & ListPropertiesType]; |
There was a problem hiding this comment.
Are you sure about the whole product fields(breadcrumbs, videos, outline, images...)? Lets just pick some and create new type in analytics
There was a problem hiding this comment.
It seems to me that we even had a task for that, but I couldn't find(
Anyway, looks like it's out of scope of the current task and worth a separate one.
I made a note to not forget to discuss it.
ivan-kalachikov
changed the title
|
Description
References
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-3128
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.21.0-pr-1703-51bd-51bd261d.zip